-
Notifications
You must be signed in to change notification settings - Fork 231
Add v2 macros migration guide #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c2cce5b
to
ada1809
Compare
30098cd
to
eca5545
Compare
ada1809
to
4959aa4
Compare
Starting from version 0.47.0, `snforge` will by default support Scarb versions 2.12 or newer. | ||
This is due to the migration to the Scarb V2 version of procedural macros, which are used to handle arguments like `#[test]` | ||
in `snforge`. | ||
Thanks to this migration, tools like the Cairo plugin for VSCode will start showing better, more descriptive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to this migration, tools like the Cairo plugin for VSCode will start showing better, more descriptive | |
As a result of this migration, tools like the Cairo plugin for VSCode will start showing better, more descriptive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to emphasize that this migration is beneficial.
4959aa4
to
aaf2888
Compare
eca5545
to
3f90191
Compare
aaf2888
to
bc19fd0
Compare
commit-id:5f7f388c # Conflicts: # crates/snforge-scarb-plugin/Cargo.lock
3f90191
to
9c07719
Compare
bc19fd0
to
91d2487
Compare
commit-id:d71f675d # Conflicts: # snforge_std/src/cheatcodes/execution_info.cairo # Conflicts: # crates/cheatnet/tests/contracts/src/cheat_tx_info/tx_info_checker_library_call.cairo # crates/cheatnet/tests/contracts/src/events/spy_events_cairo0.cairo # crates/cheatnet/tests/contracts/src/events/spy_events_lib_call.cairo # crates/cheatnet/tests/contracts/src/starknet/forking_checker.cairo # crates/sncast/tests/data/scripts/call/src/invalid_address.cairo # crates/sncast/tests/data/scripts/call/src/invalid_calldata.cairo # crates/sncast/tests/data/scripts/call/src/invalid_entry_point.cairo # crates/sncast/tests/data/scripts/declare/src/fee_settings.cairo # crates/sncast/tests/data/scripts/declare/src/insufficient_account_balance.cairo # crates/sncast/tests/data/scripts/declare/src/no_contract.cairo # crates/sncast/tests/data/scripts/declare/src/same_contract_twice.cairo # crates/sncast/tests/data/scripts/declare/src/time_out.cairo # crates/sncast/tests/data/scripts/declare/src/with_invalid_max_fee.cairo # crates/sncast/tests/data/scripts/declare/src/with_invalid_nonce.cairo # crates/sncast/tests/data/scripts/deploy/src/fee_settings.cairo # crates/sncast/tests/data/scripts/deploy/src/invalid_calldata.cairo # crates/sncast/tests/data/scripts/deploy/src/invalid_class_hash.cairo # crates/sncast/tests/data/scripts/deploy/src/invalid_nonce.cairo # crates/sncast/tests/data/scripts/deploy/src/same_class_hash_and_salt.cairo # crates/sncast/tests/data/scripts/deploy/src/with_calldata.cairo # crates/sncast/tests/data/scripts/invoke/src/contract_does_not_exist.cairo # crates/sncast/tests/data/scripts/invoke/src/max_fee_too_low.cairo # crates/sncast/tests/data/scripts/invoke/src/wrong_calldata.cairo # crates/sncast/tests/data/scripts/invoke/src/wrong_function_name.cairo # crates/sncast/tests/data/scripts/misc/src/call_fail.cairo # crates/sncast/tests/data/scripts/misc/src/call_happy.cairo # crates/sncast/tests/data/scripts/missing_field/src/missing_field.cairo # crates/sncast/tests/data/scripts/old_sncast_std/scripts/src/map_script.cairo # crates/sncast/tests/data/scripts/packages/crates/scripts/script2/src/lib.cairo # crates/sncast/tests/data/scripts/tx_status/src/status_reverted.cairo # Conflicts: # snforge_std/src/lib.cairo # Conflicts: # docs/listings/testing_contract_internals/src/basic_example.cairo
Closes #3096 commit-id:3ae67c8b
Closes #3078 commit-id:5e47ad12 # Conflicts: # crates/forge/tests/integration/gas.rs # Conflicts: # crates/forge/tests/integration/gas.rs
commit-id:34dd50be # Conflicts: # crates/forge/tests/e2e/mod.rs
91d2487
to
4735949
Compare
5dbf277
to
cf5fcb2
Compare
4735949
to
a2e6c9d
Compare
✓ Commit merged in pull request #3573 |
Pull request was closed
commit-id:d5868aee
Stack:
supports-panic-backtrace
test condition #3503_std
packages #3470snforge_std
orsnforge_std_compatibility
insnforge
new #3466_compatibility
plugin #3465_compatibility
package #3464scarbfmt
#3419