Skip to content

Add v2 macros migration guide #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Add v2 macros migration guide #3559

wants to merge 13 commits into from

Conversation

Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about having a label/banner at the top of the page, right above this place?
image

It will be way more eye-catching then 😆

@cptartur cptartur force-pushed the spr/master/d5868aee branch from c2cce5b to ada1809 Compare July 21, 2025 11:57
@cptartur cptartur requested review from ddoktorski and removed request for MKowalski8 July 21, 2025 11:58
@cptartur cptartur force-pushed the spr/master/fa08970b branch from 30098cd to eca5545 Compare July 21, 2025 13:47
@cptartur cptartur force-pushed the spr/master/d5868aee branch from ada1809 to 4959aa4 Compare July 21, 2025 13:47
Starting from version 0.47.0, `snforge` will by default support Scarb versions 2.12 or newer.
This is due to the migration to the Scarb V2 version of procedural macros, which are used to handle arguments like `#[test]`
in `snforge`.
Thanks to this migration, tools like the Cairo plugin for VSCode will start showing better, more descriptive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thanks to this migration, tools like the Cairo plugin for VSCode will start showing better, more descriptive
As a result of this migration, tools like the Cairo plugin for VSCode will start showing better, more descriptive

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to emphasize that this migration is beneficial.

@cptartur cptartur force-pushed the spr/master/fa08970b branch from eca5545 to 3f90191 Compare July 23, 2025 17:08
@cptartur cptartur force-pushed the spr/master/d5868aee branch from aaf2888 to bc19fd0 Compare July 23, 2025 17:08
commit-id:5f7f388c

# Conflicts:
#	crates/snforge-scarb-plugin/Cargo.lock
@cptartur cptartur force-pushed the spr/master/fa08970b branch from 3f90191 to 9c07719 Compare July 24, 2025 14:42
@cptartur cptartur mentioned this pull request Jul 24, 2025
@cptartur cptartur force-pushed the spr/master/d5868aee branch from bc19fd0 to 91d2487 Compare July 24, 2025 14:42
cptartur added 4 commits July 24, 2025 16:44
commit-id:d71f675d

# Conflicts:
#	snforge_std/src/cheatcodes/execution_info.cairo

# Conflicts:
#	crates/cheatnet/tests/contracts/src/cheat_tx_info/tx_info_checker_library_call.cairo
#	crates/cheatnet/tests/contracts/src/events/spy_events_cairo0.cairo
#	crates/cheatnet/tests/contracts/src/events/spy_events_lib_call.cairo
#	crates/cheatnet/tests/contracts/src/starknet/forking_checker.cairo
#	crates/sncast/tests/data/scripts/call/src/invalid_address.cairo
#	crates/sncast/tests/data/scripts/call/src/invalid_calldata.cairo
#	crates/sncast/tests/data/scripts/call/src/invalid_entry_point.cairo
#	crates/sncast/tests/data/scripts/declare/src/fee_settings.cairo
#	crates/sncast/tests/data/scripts/declare/src/insufficient_account_balance.cairo
#	crates/sncast/tests/data/scripts/declare/src/no_contract.cairo
#	crates/sncast/tests/data/scripts/declare/src/same_contract_twice.cairo
#	crates/sncast/tests/data/scripts/declare/src/time_out.cairo
#	crates/sncast/tests/data/scripts/declare/src/with_invalid_max_fee.cairo
#	crates/sncast/tests/data/scripts/declare/src/with_invalid_nonce.cairo
#	crates/sncast/tests/data/scripts/deploy/src/fee_settings.cairo
#	crates/sncast/tests/data/scripts/deploy/src/invalid_calldata.cairo
#	crates/sncast/tests/data/scripts/deploy/src/invalid_class_hash.cairo
#	crates/sncast/tests/data/scripts/deploy/src/invalid_nonce.cairo
#	crates/sncast/tests/data/scripts/deploy/src/same_class_hash_and_salt.cairo
#	crates/sncast/tests/data/scripts/deploy/src/with_calldata.cairo
#	crates/sncast/tests/data/scripts/invoke/src/contract_does_not_exist.cairo
#	crates/sncast/tests/data/scripts/invoke/src/max_fee_too_low.cairo
#	crates/sncast/tests/data/scripts/invoke/src/wrong_calldata.cairo
#	crates/sncast/tests/data/scripts/invoke/src/wrong_function_name.cairo
#	crates/sncast/tests/data/scripts/misc/src/call_fail.cairo
#	crates/sncast/tests/data/scripts/misc/src/call_happy.cairo
#	crates/sncast/tests/data/scripts/missing_field/src/missing_field.cairo
#	crates/sncast/tests/data/scripts/old_sncast_std/scripts/src/map_script.cairo
#	crates/sncast/tests/data/scripts/packages/crates/scripts/script2/src/lib.cairo
#	crates/sncast/tests/data/scripts/tx_status/src/status_reverted.cairo

# Conflicts:
#	snforge_std/src/lib.cairo

# Conflicts:
#	docs/listings/testing_contract_internals/src/basic_example.cairo
Closes #3096

commit-id:3ae67c8b
Closes #3078

commit-id:5e47ad12

# Conflicts:
#	crates/forge/tests/integration/gas.rs

# Conflicts:
#	crates/forge/tests/integration/gas.rs
commit-id:34dd50be

# Conflicts:
#	crates/forge/tests/e2e/mod.rs
@cptartur cptartur force-pushed the spr/master/d5868aee branch from 91d2487 to 4735949 Compare July 24, 2025 14:45
cptartur and others added 8 commits July 25, 2025 15:37
@cptartur cptartur force-pushed the spr/master/fa08970b branch from 5dbf277 to cf5fcb2 Compare July 25, 2025 13:55
@cptartur cptartur force-pushed the spr/master/d5868aee branch from 4735949 to a2e6c9d Compare July 25, 2025 13:55
@cptartur cptartur changed the base branch from spr/master/fa08970b to master July 25, 2025 13:57
@cptartur cptartur enabled auto-merge July 25, 2025 13:57
@cptartur
Copy link
Member Author

✓ Commit merged in pull request #3573

@cptartur cptartur closed this Jul 25, 2025
auto-merge was automatically disabled July 25, 2025 13:58

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants