Skip to content

Remove supports-panic-backtrace test condition #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 6cbff31 to 05e97c2 Compare June 27, 2025 14:38
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 06b34c9 to 6b483d5 Compare June 27, 2025 14:53
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch 2 times, most recently from ff3627e to 33ae496 Compare June 27, 2025 14:54
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 2 times, most recently from 792d9d7 to d181402 Compare June 27, 2025 14:57
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 33ae496 to 673d686 Compare June 27, 2025 14:57
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from d181402 to 9d73856 Compare July 1, 2025 13:14
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 673d686 to f4a6047 Compare July 1, 2025 13:14
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 9d73856 to 0196e33 Compare July 1, 2025 13:16
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from f4a6047 to 938e5ca Compare July 1, 2025 13:16
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 0196e33 to db92b64 Compare July 1, 2025 13:25
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch 2 times, most recently from c1721e4 to 24bdc2e Compare July 1, 2025 13:53
@cptartur cptartur marked this pull request as ready for review July 1, 2025 13:58
@cptartur cptartur requested a review from a team as a code owner July 1, 2025 13:58
@cptartur cptartur requested review from ddoktorski, franciszekjob and kkawula and removed request for a team July 1, 2025 13:58
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 2deced8 to 812d868 Compare July 10, 2025 13:50
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 8f8951e to aa92710 Compare July 10, 2025 13:50
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 812d868 to b61a6c4 Compare July 10, 2025 17:12
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from aa92710 to d2431f5 Compare July 10, 2025 17:12
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from b61a6c4 to b664e62 Compare July 14, 2025 16:17
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 716c0dc to 52ed540 Compare July 14, 2025 16:34
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from b664e62 to 6c35a9d Compare July 14, 2025 16:34
@cptartur
Copy link
Member Author

Would it be better to have feature for scarb 2.12.* instead of running scarb to check version?

We'll use Scarb 2.12 as a default version (after it is released), check for scarb version is just to enable compatibility with scheduled tests running on older scarb. After 2.14 the check will be obsolete.

So maybe let's add feature for that. I would say this is our standard procedure and when you delete it cargo automatically shows places, where you referenced this

Since a lot of tests depends on runtime checks for scarb version (they need to pick either compatibility or standard package) I think it's easier to just do the same for backtrace.
Otherwise we still will have runtime checks for versions before 2.11 just not for backtrace.

@cptartur cptartur requested a review from ksew1 July 18, 2025 11:10
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 6c35a9d to ca0a82a Compare July 18, 2025 11:19
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 20796c0 to 8d17d4b Compare July 18, 2025 13:44
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch 3 times, most recently from d09878a to 0085c56 Compare July 18, 2025 13:55
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 0085c56 to d114d09 Compare July 21, 2025 11:57
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from fc62f0c to a9a8422 Compare July 21, 2025 11:57
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch 2 times, most recently from 922149a to 4debaf3 Compare July 23, 2025 17:08
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 7c35cb8 to 2ac01c0 Compare July 24, 2025 14:42
@cptartur cptartur mentioned this pull request Jul 24, 2025
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 4debaf3 to 1bb6493 Compare July 24, 2025 14:42
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 2ac01c0 to ed7fc7a Compare July 24, 2025 14:45
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from 1bb6493 to f77ab9e Compare July 24, 2025 14:45
@cptartur cptartur force-pushed the spr/master/9d3bc55c branch from f77ab9e to 7bb7b2a Compare July 25, 2025 13:55
@cptartur
Copy link
Member Author

✓ Commit merged in pull request #3559

@cptartur cptartur closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants