Skip to content

Add tests for diagnostics #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add tests for diagnostics #3424

wants to merge 1 commit into from

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented May 28, 2025 •
edited
Loading

This was referenced May 28, 2025
Closed
Closed
Closed
Closed
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 21c5990 to 5be149f Compare May 28, 2025 16:29
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from bd12e0a to d5cda9e Compare May 28, 2025 16:35
@cptartur cptartur force-pushed the spr/master/34dd50be branch 5 times, most recently from db65aa3 to 39abdfc Compare June 4, 2025 07:58
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 39abdfc to f23f3b6 Compare June 11, 2025 09:02
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from e7643c3 to 75c18b8 Compare June 11, 2025 09:05
@cptartur cptartur force-pushed the spr/master/34dd50be branch 5 times, most recently from 50c1bcf to 706f71a Compare June 12, 2025 16:46
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 4182e0e to ea3b359 Compare June 13, 2025 09:03
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 706f71a to f41bcbb Compare June 13, 2025 09:03
This was referenced Jun 13, 2025
Closed
Closed
Closed
Closed
Closed
@cptartur cptartur force-pushed the spr/master/34dd50be branch from f41bcbb to bc976b1 Compare June 27, 2025 14:34
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from ea3b359 to b0ef916 Compare June 27, 2025 14:34
This was referenced Jun 27, 2025
Closed
Closed
@cptartur cptartur force-pushed the spr/master/34dd50be branch from bc976b1 to 7c4239e Compare July 1, 2025 13:14
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 5ef07eb to 74e5dfb Compare July 10, 2025 10:39
@cptartur cptartur force-pushed the spr/master/34dd50be branch 2 times, most recently from 06ff090 to 71bd60f Compare July 10, 2025 13:50
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 74e5dfb to cf71b49 Compare July 10, 2025 17:12
@cptartur cptartur force-pushed the spr/master/34dd50be branch 2 times, most recently from 2da953d to e63dbb2 Compare July 14, 2025 16:17
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from cf71b49 to 52de983 Compare July 14, 2025 16:17
@cptartur cptartur mentioned this pull request Jul 15, 2025
Closed
@cptartur cptartur requested a review from ddoktorski July 18, 2025 11:05
@cptartur cptartur force-pushed the spr/master/34dd50be branch from e63dbb2 to 6097ab8 Compare July 18, 2025 11:19
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 52de983 to 660befc Compare July 18, 2025 11:19
ddoktorski
ddoktorski approved these changes Jul 18, 2025
View reviewed changes
crates/forge/tests/data/diagnostics/attributes/tests/contract.cairo Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we move content of this file to the lib.cairo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd have to be in the #[cfg(tests)] module there, we want to compile it as a test target. It's easier to keep it in tests/ directory instead.

@cptartur cptartur force-pushed the spr/master/34dd50be branch from 6097ab8 to 315f09d Compare July 18, 2025 13:44
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch 2 times, most recently from 8a340f4 to b185ce6 Compare July 18, 2025 13:47
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 315f09d to cdeb859 Compare July 18, 2025 13:47
@cptartur cptartur mentioned this pull request Jul 18, 2025
Closed
@cptartur cptartur force-pushed the spr/master/34dd50be branch from cdeb859 to 338a09e Compare July 21, 2025 11:57
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 458b46c to 7a2a8a0 Compare July 21, 2025 13:47
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 338a09e to 254b966 Compare July 21, 2025 13:48
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 7a2a8a0 to 9b02743 Compare July 23, 2025 17:08
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 254b966 to 296ca12 Compare July 23, 2025 17:08
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 9b02743 to 3766b57 Compare July 24, 2025 14:42
@cptartur cptartur mentioned this pull request Jul 24, 2025
Open
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 296ca12 to 5fa22b4 Compare July 24, 2025 14:42
@cptartur
Add tests for diagnostics
714d659 
commit-id:34dd50be

# Conflicts:
#	crates/forge/tests/e2e/mod.rs
@cptartur cptartur force-pushed the spr/master/5e47ad12 branch from 3766b57 to 8e48940 Compare July 24, 2025 14:45
@cptartur cptartur force-pushed the spr/master/34dd50be branch from 5fa22b4 to 714d659 Compare July 24, 2025 14:45
@cptartur
Copy link
Member Author

✓ Commit merged in pull request #3559

@cptartur cptartur closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cptartur @ddoktorski @franciszekjob