Skip to content

lang: [it] Added the remaining translations for the Italian language #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2025

Conversation

Franky5831
Copy link
Contributor

Description
I added the remaining translations for the Italian language.
I noticed some translations were missing, I translated all the remaining strings (I am Italian).

I took some light liberties on the following translations:

  1. bannedUser => I translated "you are currently banned" to "l'account è stato disabilitato" which means "the account has been disabled"
  2. logOutBannedUser => I translated "you have been banned." to "l'account è stato disabilitato." which means "the account has been disabled"
  3. invalidEmail => "the email address "{0}" matches the email on record." to "l'indirizzo email "{0}" corrisponda ad un indirizzo registrato." which means "the "{0}" email address matches with a registered one."
  4. I kept "Token" as such, we don't have a word for that

Please let me know if you prefer a more more literal translation.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@Franky5831 Franky5831 changed the title Added the remaining translations for the Italian language lang: Added the remaining translations for the Italian language Jul 24, 2025
@datamweb datamweb added the lang Languages file label Jul 27, 2025
@datamweb datamweb changed the title lang: Added the remaining translations for the Italian language lang: [it] Added the remaining translations for the Italian language Jul 27, 2025
@datamweb
Copy link
Collaborator

4. I kept "Token" as such, we don't have a word for that

So, please update the test using Auth.token:

final class ItalianTranslationTest extends AbstractTranslationTestCase
{
    protected array $excludedLocaleKeyTranslations = [
        'Auth.password',
        'Auth.login',
    ];
}

As asked in this comment: codeigniter4#1282 (comment)
I Added "Auth.token" to the "ItalianTranslationTest" class.
Just like in the "CzechTranslationTest" class I removed "Auth.password" and "Auth.login" from the "$excludedLocaleKeyTranslations" array
@Franky5831
Copy link
Contributor Author

@datamweb I did it.
Also, just like in the "CzechTranslationTest" class I removed "Auth.password" and "Auth.login" from the "$excludedLocaleKeyTranslations" array.
For reference, this is the class: https://github.com/codeigniter4/shield/blob/develop/tests/Language/CzechTranslationTest.php

@Franky5831
Copy link
Contributor Author

Ok, I made a stupid mistake, I added Auth.password and Auth.login to the $excludedLocaleKeyTranslations array again.
I ran the tests on my machine using php vendor/bin/phpunit and it passed all tests.

@datamweb datamweb closed this Aug 2, 2025
@datamweb datamweb reopened this Aug 2, 2025
@datamweb
Copy link
Collaborator

datamweb commented Aug 2, 2025

@Franky5831 We had a difference of opinion regarding a security report in the CI4 framework, which caused a bit of a delay. Fortunately, after follow-ups and clarification with the team, the issue has been resolved.

Thanks again for taking the time to submit the PR — we truly appreciate your contribution. 🙏

@datamweb datamweb merged commit 692878c into codeigniter4:develop Aug 2, 2025
38 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants