[SDK] Fix ecosystem wallet connection with default chains #7708

joaquim-verges · 2025-07-25T01:03:57Z

PR-Codex overview

This PR focuses on improving the wallet connection process in the thirdweb package by refining how options are passed and ensuring compatibility with default chains.

Detailed summary

Updated the connectSmartAccount call to merge createOptions with newChain.
Removed connectChain from connectionOptions destructuring in connectSmartAccount.
Changed how chain is determined in connectSmartAccount to use creationOptions.chain.
Made options parameter optional in resolveSmartAccountOptionsFromEcosystem.
Updated calls to resolveSmartAccountOptionsFromEcosystem to omit options parameter in createInAppWallet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Improved ecosystem wallet connection reliability with default chains by ensuring correct chain handling during connection and chain switching.
Chores
- Added a changeset documenting the patch update for the wallet connection fix.

vercel · 2025-07-25T01:03:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 1:22am
nebula	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 1:22am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 1:22am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 1:22am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 1:22am

changeset-bot · 2025-07-25T01:04:00Z

🦋 Changeset detected

Latest commit: e28ae1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/nebula	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-25T01:04:03Z

Walkthrough

This update modifies wallet connection logic related to chain selection in the "thirdweb" package. The signature of resolveSmartAccountOptionsFromEcosystem now allows an optional parameter, and its usage is updated accordingly. Chain resolution logic in connectSmartAccount is simplified by removing a fallback chain. The switchChain method now explicitly sets the new chain in connection options. Additionally, a changeset file documents these adjustments as a patch fix.

Changes

File(s)	Change Summary
.changeset/slimy-pigs-rest.md	Added changeset file documenting a patch fix for ecosystem wallet connection with default chains.
packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts	Made `options` parameter optional in `resolveSmartAccountOptionsFromEcosystem` and updated callers to omit argument.
packages/thirdweb/src/wallets/smart/index.ts	Simplified chain resolution logic in `connectSmartAccount` by removing fallback to `connectChain` and using `creationOptions.chain`.
packages/thirdweb/src/wallets/smart/smart-wallet.ts	Updated `switchChain` to pass connection options with explicit `chain` override when calling `connectSmartAccount`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a60ec36 and e28ae1a.

📒 Files selected for processing (4)

.changeset/slimy-pigs-rest.md (1 hunks)
packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts (4 hunks)
packages/thirdweb/src/wallets/smart/index.ts (2 hunks)
packages/thirdweb/src/wallets/smart/smart-wallet.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

.changeset/slimy-pigs-rest.md
packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts
packages/thirdweb/src/wallets/smart/index.ts

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

Files:

packages/thirdweb/src/wallets/smart/smart-wallet.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

packages/thirdweb/src/wallets/smart/smart-wallet.ts

packages/thirdweb/src/wallets/**

📄 CodeRabbit Inference Engine (CLAUDE.md)

packages/thirdweb/src/wallets/**: Unified Wallet and Account interfaces in wallet architecture
Support for in-app wallets (social/email login)
Smart wallets with account abstraction
EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Files:

packages/thirdweb/src/wallets/smart/smart-wallet.ts

🧠 Learnings (2)

📓 Common learnings

Learnt from: joaquim-verges
PR: thirdweb-dev/js#7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to **/*.test.{ts,tsx} : Use `FORKED_ETHEREUM_CHAIN` for mainnet interactions and `ANVIL_CHAIN` for isolated tests

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)

Learnt from: MananTank
PR: thirdweb-dev/js#7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:424-424
Timestamp: 2025-06-06T23:46:08.795Z
Learning: The thirdweb project has an ESLint rule that restricts direct usage of `defineChain`. When it's necessary to use `defineChain` directly, it's acceptable to disable the rule with `// eslint-disable-next-line no-restricted-syntax`.

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to test/src/test-wallets.ts : Predefined test accounts are in `test/src/test-wallets.ts`

packages/thirdweb/src/wallets/smart/smart-wallet.ts (7)

Learnt from: joaquim-verges
PR: #7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified Wallet and Account interfaces in wallet architecture

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to **/*.test.{ts,tsx} : Use FORKED_ETHEREUM_CHAIN for mainnet interactions and ANVIL_CHAIN for isolated tests

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to test/src/test-wallets.ts : Predefined test accounts are in test/src/test-wallets.ts

Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Learnt from: MananTank
PR: #7298
File: apps/dashboard/src/app/nebula-app/move-funds/move-funds.tsx:424-424
Timestamp: 2025-06-06T23:46:08.795Z
Learning: The thirdweb project has an ESLint rule that restricts direct usage of defineChain. When it's necessary to use defineChain directly, it's acceptable to disable the rule with // eslint-disable-next-line no-restricted-syntax.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Size
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Lint Packages
GitHub Check: Build Packages
GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

packages/thirdweb/src/wallets/smart/smart-wallet.ts (1)

232-232: LGTM! Ensures consistent chain usage during smart wallet reconnection.

The explicit chain override in createOptions ensures that both connection and creation options use the new chain consistently during the chain switch operation. This aligns with the EIP4337 smart wallet requirement for reconnection when switching chains.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch _SDK_Fix_ecosystem_wallet_connection_with_default_chains

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-25T01:09:31Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	63.33 KB (0%)	1.3 s (0%)	350 ms (+102.84% 🔺)	1.7 s
thirdweb (cjs)	353.15 KB (0%)	7.1 s (0%)	1.4 s (+0.82% 🔺)	8.4 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	89 ms (+883.51% 🔺)	203 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	62 ms (+1446.65% 🔺)	72 ms
thirdweb/react (minimal + tree-shaking)	19.18 KB (-0.19% 🔽)	384 ms (-0.19% 🔽)	37 ms (+57.88% 🔺)	421 ms

joaquim-verges · 2025-07-25T01:11:24Z

[SDK] Fix ecosystem wallet connection with default chains #7708 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions bot assigned joaquim-verges Jul 25, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jul 25, 2025

joaquim-verges marked this pull request as ready for review July 25, 2025 01:04

joaquim-verges requested review from a team as code owners July 25, 2025 01:04

vercel bot deployed to Preview – wallet-ui July 25, 2025 01:06 View deployment

vercel bot deployed to Preview – nebula July 25, 2025 01:06 View deployment

vercel bot deployed to Preview – thirdweb_playground July 25, 2025 01:07 View deployment

[SDK] Fix ecosystem wallet connection with default chains

e28ae1a

joaquim-verges force-pushed the _SDK_Fix_ecosystem_wallet_connection_with_default_chains branch from a60ec36 to e28ae1a Compare July 25, 2025 01:11

vercel bot deployed to Preview – wallet-ui July 25, 2025 01:13 View deployment

vercel bot deployed to Preview – nebula July 25, 2025 01:13 View deployment

vercel bot deployed to Preview – thirdweb_playground July 25, 2025 01:14 View deployment

vercel bot deployed to Preview – thirdweb-www July 25, 2025 01:21 View deployment

vercel bot deployed to Preview – docs-v2 July 25, 2025 01:22 View deployment

joaquim-verges merged commit 3c8e444 into main Jul 25, 2025
21 of 22 checks passed

joaquim-verges deleted the _SDK_Fix_ecosystem_wallet_connection_with_default_chains branch July 25, 2025 02:02

joaquim-verges mentioned this pull request Jul 25, 2025

Version Packages #7709

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix ecosystem wallet connection with default chains #7708

[SDK] Fix ecosystem wallet connection with default chains #7708

Uh oh!

joaquim-verges commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

joaquim-verges commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

[SDK] Fix ecosystem wallet connection with default chains #7708

[SDK] Fix ecosystem wallet connection with default chains #7708

Uh oh!

Conversation

joaquim-verges commented Jul 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

joaquim-verges commented Jul 25, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

joaquim-verges commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 25, 2025 •

edited

Loading

changeset-bot bot commented Jul 25, 2025 •

edited

Loading

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 25, 2025 •

edited

Loading