-
Notifications
You must be signed in to change notification settings - Fork 567
Version Packages #7709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7709
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis update consists of version bumps and changelog updates for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Provide at least a minimal release note for 0.2.118Every prior entry includes a “### Patch Changes” section (often with a PR link). Adding even a terse note maintains traceability and tooling compatibility that parse change-type headings.
## 0.2.118 +### Patch Changes +- Version bump only – aligns with `thirdweb@5.105.21`.packages/thirdweb/CHANGELOG.md (1)
3-8
: Add release date for consistency across changelog entriesRecent versions (e.g.,
5.105.20
) include the release date next to the version header, which helps consumers track when fixes landed. Adding the date here keeps formatting uniform and aids auditability.Example:
## 5.105.21 – 2025-07-19
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/slimy-pigs-rest.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/slimy-pigs-rest.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.md
packages/wagmi-adapter/package.json
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture
Learnt from: joaquim-verges
PR: thirdweb-dev/js#7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.
packages/thirdweb/package.json (3)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via exports/
directory, grouped by feature in the SDK public API
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Every public symbol must have comprehensive TSDoc with at least one @example
block that compiles and custom annotation tags (@beta
, @internal
, @experimental
)
packages/nebula/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in packages/wagmi-adapter/
packages/nebula/package.json (3)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via exports/
directory, grouped by feature in the SDK public API
Learnt from: MananTank
PR: #7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Every public symbol must have comprehensive TSDoc with at least one @example
block that compiles and custom annotation tags (@beta
, @internal
, @experimental
)
packages/wagmi-adapter/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in packages/wagmi-adapter/
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via exports/
directory, grouped by feature in the SDK public API
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Every public symbol must have comprehensive TSDoc with at least one @example
block that compiles and custom annotation tags (@beta
, @internal
, @experimental
)
Learnt from: MananTank
PR: #7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/thirdweb/CHANGELOG.md (6)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified Wallet
and Account
interfaces in wallet architecture
Learnt from: joaquim-verges
PR: #7268
File: packages/thirdweb/src/wallets/in-app/core/wallet/in-app-core.ts:210-216
Timestamp: 2025-06-03T23:44:40.243Z
Learning: EIP7702 wallets do not need special handling for switching chains, unlike EIP4337 wallets which require reconnection when switching chains. In the switchChain method condition, EIP7702 should be intentionally excluded from the reconnection logic.
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/wagmi-adapter/package.json (1)
56-59
: Version bump looks good
0.2.118
is within the existing peer-dependency range (^5.85.0
covers5.105.21
) and keeps semver continuity. No other metadata changed.
LGTM.packages/nebula/CHANGELOG.md (1)
3-9
: Changelog entry is clearEntry correctly calls out the dependency bump and links the fixing commit. No issues spotted.
packages/nebula/package.json (1)
60-61
: Package version bump aligns with changelogThe patch version increment to
0.2.21
matches the CHANGELOG. Good to merge.
"version": "5.105.21" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump LGTM, but double-check for hard-coded old versions elsewhere
The change is purely the patch bump to 5.105.21
, which is consistent with the PR intent.
Please run a quick grep to ensure no files still reference 5.105.20
(e.g., docs, examples, lockfiles).
🏁 Script executed:
#!/bin/bash
# Find any stale references to the previous version.
rg --fixed-strings "5.105.20" -n
Length of output: 131
Update stale version references in CHANGELOGs
We found two remaining occurrences of 5.105.20
that should be bumped to 5.105.21
:
- packages/thirdweb/CHANGELOG.md (line 9)
- packages/nebula/CHANGELOG.md (line 15)
Apply the following diffs:
packages/thirdweb/CHANGELOG.md
-## 5.105.20
+## 5.105.21
packages/nebula/CHANGELOG.md
- - thirdweb@5.105.20
+ - thirdweb@5.105.21
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"version": "5.105.21" | |
} | |
packages/thirdweb/CHANGELOG.md | |
@@ -9,1 +9,1 @@ | |
-## 5.105.20 | |
+## 5.105.21 | |
packages/nebula/CHANGELOG.md | |
@@ -15,1 +15,1 @@ | |
- - thirdweb@5.105.20 | |
+ - thirdweb@5.105.21 |
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md at line 9 and packages/nebula/CHANGELOG.md at
line 15, update the version references from 5.105.20 to 5.105.21 to keep the
changelogs consistent with the current package version. Locate these lines and
replace the old version number with the new one.
size-limit report 📦
|
bd7e895
to
70dd058
Compare
70dd058
to
1772f98
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/nebula@0.2.21
Patch Changes
3c8e444
,adec6be
]:thirdweb@5.105.21
Patch Changes
#7708
3c8e444
Thanks @joaquim-verges! - Fix ecosystem wallet connection with default chains#7711
adec6be
Thanks @joaquim-verges! - Fix showQrModal option not respected on desktop web@thirdweb-dev/wagmi-adapter@0.2.118
PR-Codex overview
This PR primarily focuses on updating version numbers in various
package.json
files and enhancing the changelogs forthirdweb
andnebula
packages to reflect recent changes and dependency updates.Detailed summary
version
inpackages/thirdweb/package.json
from5.105.20
to5.105.21
version
inpackages/nebula/package.json
from0.2.20
to0.2.21
version
inpackages/wagmi-adapter/package.json
from0.2.117
to0.2.118
thirdweb
version5.105.21
with fixes for wallet connection and QR modal optionsnebula
version0.2.21
noting updates to dependenciesSummary by CodeRabbit
Bug Fixes
Chores