Sema: Fix the -warn-long-expression-type-checking flag #82506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
artemcm and
tshortli
as code owners
xedin
approved these changes
Jun 25, 2025
slavapestov
force-pushed
the
warn-long-expression-type-checking
branch
from
7ddb47e to
f4469ac
Compare
|
@swift-ci Please smoke test |
This was referenced Jun 25, 2025
slavapestov
force-pushed
the
warn-long-expression-type-checking
branch
from
f4469ac to
7dd559c
Compare
…tency with the others
…s turned off My change 983b75e broke -warn-long-expression-type-checking because now the ExpressionTimer is not instantiated by default and that entire code path is skipped. Change it so that if -warn-long-expression-type-checking is passed in, we still start the timer, we just don't ever consider it to have 'expired'. Fixes rdar://problem/152998878.
slavapestov
force-pushed
the
warn-long-expression-type-checking
branch
from
7dd559c to
487918f
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://152998878.
This flag regressed because the test for it has been disabled since 2018. Re-enable it, "fixing" rdar://44305428.