[6.2] Sema: Fix -warn-long-expression-type-checking when expression timer is disabled #82508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 25, 2025
slavapestov
changed the title
…s turned off My change 983b75e broke -warn-long-expression-type-checking because now the ExpressionTimer is not instantiated by default and that entire code path is skipped. Change it so that if -warn-long-expression-type-checking is passed in, we still start the timer, we just don't ever consider it to have 'expired'. Fixes rdar://problem/152998878.
slavapestov
force-pushed
the
warn-long-expression-type-checking-6.2
branch
from
54e436f to
017be57
Compare
|
@swift-ci Please test |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please test macOS |
1 similar comment
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #82506
Description: The 600-second expression timeout was a source of overhead so it was turned off in 6.2 (Basic: Turn off solver expression time threshold by default #78975) but this regressed the
-warn-long-expression-type-checkingflag. We need to start the timer if either the global timeout is enabled, or the warning is on.Reviewed by: @xedin
Risk: Very low.
Radar: rdar://152998878