Fix test setup for directive tests. #13883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the "parent" attribute of RSTState instances to the `document` instead of None. The attribute holds the state machines "current node" which is initialized to the `document` in `RSTStateMachine.run()` and required since Docutils 0.22.1 in `RSTState.nested_parse()` to correctly support sections in nested parsing.
|
I have relaunched |
Thanks for confirming. Looking at https://github.com/sphinx-doc/sphinx/actions/runs/17890838608/job/50870951193, I see that now Docutils 0.22 tests now fail, too, with the same false negative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the "parent" attribute of RSTState instances to the
documentinstead of None. The attribute holds the state machines "current node" which is initialized to thedocumentinRSTStateMachine.run()and required since Docutils 0.22.1 inRSTState.nested_parse()to correctly support sections in nested parsing.Purpose
Get tests with Docutils HEAD working again.