Search: Fix word exclusion in client side search #13893
Conversation
| .filter((term) => term); // remove remaining empty strings | ||
| var splitQuery = (query) => { | ||
| const consecutiveLetters = | ||
| /[\p{Letter}\p{Number}_\p{Emoji_Presentation}]+/gu; |
There was a problem hiding this comment.
IDK if it's bad to define is regex first and reference it later in the new regex. It could also be plain text. But I thought this way, the origin of the regex can be easier understood.
| }) | ||
| ) | ||
| break; | ||
| continue; |
There was a problem hiding this comment.
This is probably the most important change!
|
Regarding the CI: I don't see any changes on my PR which would trigger the current CI fail. Is this a common issue? TBH it does not look like it's affecting the master branch too 🤔. I'm a little aimless what to do here. |
That's OK, yep - I believe that is due to bug #13886 (in progress, potentially to be fixed by #13883). |
Purpose
The built-in search is capable of excluding search terms. Thats a great feature which would make the search a lot better!
Unfortunately, there are two blocking components:
splitQuerywill discard hyphens which define the excluded termsperformTermsSearchwill abort the search if any excluded term is matchedReferences
Closes #13892