Skip to content

configs/sdm660_defconfig: support efi zboot #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: qcom-sdm660-6.15.y
Choose a base branch
from
+10 −1
Open

configs/sdm660_defconfig: support efi zboot #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion arch/arm64/configs/sdm660_defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,16 @@ CONFIG_COMPAT=y
CONFIG_COMPAT_ALIGNMENT_FIXUPS=y
CONFIG_RANDOMIZE_BASE=y
CONFIG_CMDLINE_DROP_DANGEROUS_ANDROID_OPTIONS=y
# CONFIG_EFI is not set
#
# EFI (Extensible Firmware Interface) Support
#
CONFIG_HAVE_KERNEL_ZSTD=y
CONFIG_KERNEL_ZSTD=y
CONFIG_EFI=y
CONFIG_EFI_STUB=y
CONFIG_EFI_GENERIC_STUB=y
CONFIG_EFI_ZBOOT=y
CONFIG_EFI_ARMSTUB_DTB_LOADER=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some of these are user-selectable (have prompt and descriptive help text), others are probably selected automatically and therefore should not be in defconfig. That's why I think you did not generate this defconfig properly, it should be done using:

# (in build dir, which is usually a subdirectory in linux source)
make savedefconfig # generates "defconfig" file
cp defconfig ../arch/arm64/configs/sdm660_defconfig

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, I'll come back and fix this in a bit. Feel free to push this branch if you want to fix it, but if not I'll finish up another time.

CONFIG_HIBERNATION=y
CONFIG_WQ_POWER_EFFICIENT_DEFAULT=y
CONFIG_CPU_IDLE=y
Expand Down
Loading