-
Notifications
You must be signed in to change notification settings - Fork 19
configs/sdm660_defconfig: support efi zboot #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: qcom-sdm660-6.15.y
Are you sure you want to change the base?
Conversation
Signed-off-by: Paul Sajna <hello@paulsajna.com>
CI failure: missing dependency on runner
|
This now turned into
Which is like the only one thing I'm worried about here, that there is no more |
The commit that fixed absence of hexdump btw... |
maybe if I enable gzip instead of zstd it would build both? I'll try fiddling with it. |
No, I don't think it will help, the question is can e.g grub load regular linux kernel without turning it into EFI application? |
The https://cateee.net/lkddb/web-lkddb/EFI.html says
The configuration item
I hope this will not make booting with U-Boot mandatory, not all our devices have U-Boot port |
CONFIG_EFI_STUB=y | ||
CONFIG_EFI_GENERIC_STUB=y | ||
CONFIG_EFI_ZBOOT=y | ||
CONFIG_EFI_ARMSTUB_DTB_LOADER=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some of these are user-selectable (have prompt and descriptive help text), others are probably selected automatically and therefore should not be in defconfig. That's why I think you did not generate this defconfig properly, it should be done using:
# (in build dir, which is usually a subdirectory in linux source)
make savedefconfig # generates "defconfig" file
cp defconfig ../arch/arm64/configs/sdm660_defconfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip, I'll come back and fix this in a bit. Feel free to push this branch if you want to fix it, but if not I'll finish up another time.
SDM845 kernel manages to build all 3. I'll have to figure out where I went wrong. |
sdm845 kernel package is manually copying and renaming files, I do not believe that's the intended way of doing things. Maybe that's because of how differently files are named in case of EFI enabled, but still.. We just do |
Add some config options to generate a vmlinuz.efi for systemd-boot.