Skip to content

sap_*_preconfigure/SLES: Enhance saptune handling and detection #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

marcelmamula
Copy link
Contributor

Description:

New features

  1. Introduced new variable with zypper patterns, which will be used with command instead of package module.
    • Reason: package module does not run zypper in default mode and it skips Recommends packages, resulting in discrepancines.
    • Example: Pattern sap-hana recommends packages that install libltdl7, but package will not install it when using rpm of pattern: patterns-sap-hana
  2. Introduced new variables sap_hana_preconfigure_saptune_solution_force and sap_netweaver_preconfigure_saptune_solution_force that allow forcing application of saptune solution regardless if it is already enabled and verified.
    • This follows recommendation that fresh re-enablement is always correct way to go, but variable is false by default.

Fixes

  1. Reverted commit 0dc982c
  2. Fixed typo in saptune variable validation, resulting in skipping block
  3. Re-enabled validation using saptune solution enabled after finding edge case where NETWEAVER can be successfully verified on host with HANA applied (overlap of parameters)
  4. Updated RedHat specific variable comments with (RedHat specific) where appropriate: sap_general_preconfigure_packagegroups, sap_general_preconfigure_envgroups
  5. Removed saptune solution enabled check from saptune_takeover as it is not necessary, since it is done in configuration step as well.

Testing

All preconfigure roles were tested on SLES 15 SP6 and SLES4SAP 15 SP6

@marcelmamula marcelmamula added bug Something isn't working enhancement New feature or request labels Mar 6, 2025
@marcelmamula marcelmamula requested a review from berndfinger March 6, 2025 12:19
@marcelmamula marcelmamula self-assigned this Mar 6, 2025
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@berndfinger berndfinger merged commit 70d3dd9 into sap-linuxlab:dev Mar 6, 2025
6 checks passed
@marcelmamula marcelmamula deleted the patterns branch April 2, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants