Merge pull request #994 from marcelmamula/patterns

sap_*_preconfigure/SLES: Enhance saptune handling and detection

Author: berndfinger

roles/sap_general_preconfigure/README.md

@@ -258,7 +258,7 @@ If you set the RHEL minor release, then you must also use the `eus` or `e4s` rep
 - _Type:_ `str`
 - _Default:_ (set by platform/environment specific variables)
 
-The name of the software package group to install.<br>
+(RedHat specific) The name of the software package group to install.<br>
 The default for this parameter is set in the vars file which corresponds to the detected OS version.<br>
 
 Example:
@@ -271,7 +271,7 @@ Example:
 - _Type:_ `str`
 - _Default:_ (set by platform/environment specific variables)
 
-The name of the software environment group to check.<br>
+(RedHat specific) The name of the software environment group to check.<br>
 The default for this parameter is set in the vars file which corresponds to the detected OS version.<br>
 
 Example:
@@ -280,6 +280,13 @@ Example:
 '@minimal-environment'
 ```
 
+### sap_general_preconfigure_patterns
+- _Type:_ `list` with elements of type `str`
+- _Default:_ (set by platform/environment specific variables)
+
+(SUSE specific) The list of the zypper patterns to install.<br>
+The default for this parameter is set in the vars file which corresponds to the detected OS version.<br>
+
 ### sap_general_preconfigure_packages
 - _Type:_ `list` with elements of type `str`
 - _Default:_ (set by platform/environment specific variables)

roles/sap_general_preconfigure/defaults/main.yml

@@ -69,15 +69,19 @@ sap_general_preconfigure_set_minor_release: false
 # If you set the RHEL minor release, then you must also use the `eus` or `e4s` repos.
 
 sap_general_preconfigure_packagegroups: "{{ __sap_general_preconfigure_packagegroups }}"
-# The name of the software package group to install.
+# (RedHat specific) The name of the software package group to install.
 # The default for this parameter is set in the vars file which corresponds to the detected OS version.
 # Example: See README.md
 
 sap_general_preconfigure_envgroups: "{{ __sap_general_preconfigure_envgroups }}"
-# The name of the software environment group to check.
+# (RedHat specific) The name of the software environment group to check.
 # The default for this parameter is set in the vars file which corresponds to the detected OS version.
 # Example: See README.md
 
+sap_general_preconfigure_patterns: "{{ __sap_general_preconfigure_patterns }}"
+# (SUSE specific) The list of the zypper patterns to install.
+# The default for this parameter is set in the vars file which corresponds to the detected OS version.
+
 sap_general_preconfigure_packages: "{{ __sap_general_preconfigure_packages }}"
 # The list of packages to be installed.
 # The default for this variable is set in the vars file which corresponds to the detected OS version.

roles/sap_general_preconfigure/meta/argument_specs.yml

@@ -152,7 +152,7 @@ argument_specs:
       sap_general_preconfigure_packagegroups:
         default: "{{ __sap_general_preconfigure_packagegroups }}"
         description:
-          - The name of the software package group to install.
+          - (RedHat specific) The name of the software package group to install.
           - The default for this parameter is set in the vars file which corresponds to the detected OS version.
         example:
           '@minimal-environment'
@@ -162,13 +162,22 @@ argument_specs:
       sap_general_preconfigure_envgroups:
         default: "{{ __sap_general_preconfigure_envgroups }}"
         description:
-          - The name of the software environment group to check.
+          - (RedHat specific) The name of the software environment group to check.
           - The default for this parameter is set in the vars file which corresponds to the detected OS version.
         example:
           '@minimal-environment'
         required: false
         type: str
 
+      sap_general_preconfigure_patterns:
+        default: "{{ __sap_general_preconfigure_patterns }}"
+        description:
+          - (SUSE specific) The list of the zypper patterns to install.
+          - The default for this parameter is set in the vars file which corresponds to the detected OS version.
+        required: false
+        type: list
+        elements: str
+
       sap_general_preconfigure_packages:
         default: "{{ __sap_general_preconfigure_packages }}"
         description:

roles/sap_general_preconfigure/tasks/SLES/assert-installation.yml

@@ -1,6 +1,22 @@
 # SPDX-License-Identifier: Apache-2.0
 ---
 
+- name: Query installed zypper patterns
+  ansible.builtin.command:
+    cmd: zypper patterns --installed-only
+  register: __sap_general_preconfigure_register_patterns
+  changed_when: false
+  ignore_errors: true
+
+- name: Assert that all required zypper patterns are installed
+  ansible.builtin.assert:
+    that: "'{{ item }}' in __sap_general_preconfigure_register_patterns.stdout"
+    fail_msg: "FAIL: Pattern '{{ item }}' is not installed!"
+    success_msg: "PASS: Pattern '{{ item }}' is installed."
+  loop: "{{ sap_general_preconfigure_patterns }}"
+  ignore_errors: "{{ sap_general_preconfigure_assert_ignore_errors | d(false) }}"
+
+
 # Both sap_general_preconfigure_packages and __sap_general_preconfigure_min_pkgs are checked at same time.
 # Check rpm --whatprovides only if package cannot be found directly.
 - name: Query RPM packages

roles/sap_general_preconfigure/tasks/SLES/generic/saptune_takeover.yml

@@ -62,27 +62,29 @@
       changed_when: false
 
 
-- name: Check active saptune solution
+- name: Block to show current enabled saptune solution
   when:
     - __sap_general_preconfigure_use_saptune
     - __sap_general_preconfigure_register_saptune_check_before.rc == 0
       or (__sap_general_preconfigure_register_saptune_check_after.rc == 0)
   block:
-    - name: Discover active solution
+    - name: Get current enabled saptune solution
       ansible.builtin.command:
         cmd: saptune solution enabled
-      register: __sap_general_preconfigure_register_saptune_status
+      register: __sap_general_preconfigure_register_saptune_enabled
       changed_when: false
+      failed_when: false
 
-    - name: Set fact for active solution
+    # Enabled solution contains newline, which has to be removed
+    - name: Cleanup saptune solution enabled output
       ansible.builtin.set_fact:
-        # Capture the first block on none whitespace
-        __sap_general_preconfigure_register_solution_configured:
-          "{{ (__sap_general_preconfigure_register_saptune_status.stdout | regex_search('(\\S+)', '\\1'))[0] | default('NONE') }}"
+        __sap_general_preconfigure_register_saptune_enabled_trim:
+          "{{ __sap_general_preconfigure_register_saptune_enabled.stdout | trim | replace('\n', '') }}"
 
-    - name: Show configured solution
+    - name: Show current enabled saptune solution
       ansible.builtin.debug:
-        var: __sap_general_preconfigure_register_solution_configured
+        msg: "{{ __sap_general_preconfigure_register_saptune_enabled_trim }}"
+      when: __sap_general_preconfigure_register_saptune_enabled_trim != ''
 
 
 - name: Enable sapconf

roles/sap_general_preconfigure/tasks/SLES/installation.yml

@@ -29,6 +29,22 @@
   when: "'packagekit.service' in ansible_facts.services"
 
 
+# Pattern installation will run only if pattern is not installed
+# This ensures that command module shows correct changed status
+- name: Query installed zypper patterns
+  ansible.builtin.command:
+    cmd: zypper patterns --installed-only
+  register: __sap_general_preconfigure_register_patterns
+  changed_when: false
+  ignore_errors: true
+
+- name: Ensure that the required zypper patterns are installed
+  ansible.builtin.command:
+    cmd: zypper install -y -t pattern {{ item }}
+  loop: "{{ sap_general_preconfigure_patterns }}"
+  when: item not in __sap_general_preconfigure_register_patterns.stdout
+  changed_when: item not in __sap_general_preconfigure_register_patterns.stdout
+
 - name: Ensure that the required packages are installed
   ansible.builtin.package:
     state: present

roles/sap_general_preconfigure/vars/SLES_15.yml

@@ -9,7 +9,13 @@ __sap_general_preconfigure_sapnotes_versions:
   # 2369910 - SAP Software on Linux: General information
   - { number: '2369910', version: '18' }
 
+__sap_general_preconfigure_patterns:
+  - sap_server
+
 __sap_general_preconfigure_packages:
+  # Patterns are not included in package list
+  # Ansible package module skips recommended packages resulting in discrepancies.
+
   - uuidd
   - tcsh
   - psmisc

roles/sap_general_preconfigure/vars/SLES_SAP_15.yml

@@ -9,9 +9,12 @@ __sap_general_preconfigure_sapnotes_versions:
   # 2369910 - SAP Software on Linux: General information
   - { number: '2369910', version: '18' }
 
+__sap_general_preconfigure_patterns:
+  - sap_server
+
 __sap_general_preconfigure_packages:
-  # Mandatory patterns
-  - patterns-server-enterprise-sap_server
+  # Patterns are not included in package list
+  # Ansible package module skips recommended packages resulting in discrepancies.
 
   # Recommended packages
   - tcsh

roles/sap_general_preconfigure/vars/SLES_SAP_16.yml

@@ -5,9 +5,12 @@
 
 __sap_general_preconfigure_sapnotes_versions: []
 
+__sap_general_preconfigure_patterns:
+  - sles_minimal_sap
+
 __sap_general_preconfigure_packages:
-  # Mandatory patterns
-  - patterns-sap-base_sap_server
+  # Patterns are not included in package list
+  # Ansible package module skips recommended packages resulting in discrepancies.
 
   # Recommended packages
   - tcsh

roles/sap_general_preconfigure/vars/main.yml

@@ -4,6 +4,7 @@
 # dummy entries for passing the arg spec validation:
 __sap_general_preconfigure_packagegroups: ''
 __sap_general_preconfigure_envgroups: ''
+__sap_general_preconfigure_patterns: []
 __sap_general_preconfigure_packages: []
 __sap_general_preconfigure_size_of_tmpfs_gb: ''
 __sap_general_preconfigure_kernel_parameters_default: []