Skip to content

chore(l1): change logs in hive to info by default #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025

Conversation

fedacking
Copy link
Contributor

Motivation

In the PR #2975 the default value for the make run-hive was changed to error. I propose changing this to info (3), as we usually run make hive to try to see a problem with the test. For the CI I propose we change it to log level error (1), as we can't actually look at those logs.

Description

  • Changed makefile SIM_LOG_LEVEL default value to 3 (info)
  • Added to the ci workflows --sim.loglevel 1 which corresponds to error.

@fedacking fedacking requested a review from a team as a code owner July 22, 2025 14:42
@github-actions github-actions bot added the L1 Ethereum client label Jul 22, 2025
@fedacking fedacking added ci Github actions, build, tests, etc tooling External and Internal tooling that makes it easier to test the client labels Jul 22, 2025
Copy link
Contributor

@Mechanix97 Mechanix97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Jul 23, 2025
@fedacking fedacking added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit c1778ea Jul 23, 2025
34 checks passed
@fedacking fedacking deleted the chore-increse-hive-logs branch July 23, 2025 14:01
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Github actions, build, tests, etc L1 Ethereum client tooling External and Internal tooling that makes it easier to test the client
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants