Skip to content

Commit c1778ea

Browse files
authored
chore(l1): change logs in hive to info by default (#3767)
**Motivation** In the PR #2975 the default value for the `make run-hive` was changed to error. I propose changing this to info (3), as we usually run make hive to try to see a problem with the test. For the CI I propose we change it to log level error (1), as we can't actually look at those logs. **Description** - Changed makefile `SIM_LOG_LEVEL` default value to 3 (info) - Added to the ci workflows `--sim.loglevel 1` which corresponds to error.
1 parent 3f60642 commit c1778ea

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/common_hive_reports.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
fi
8686
8787
- name: Run Hive Simulation
88-
run: cd hive && ./hive --client-file ../fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.test.simulation }} --sim.parallelism 16 ${{ env.HIVE_FLAGS }}
88+
run: cd hive && ./hive --client-file ../fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.test.simulation }} --sim.parallelism 16 ${{ env.HIVE_FLAGS }} --sim.loglevel 1
8989
continue-on-error: true
9090

9191
- name: Upload results

.github/workflows/pr-main_l1.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ jobs:
214214
docker load --input /tmp/ethrex_image.tar
215215
216216
- name: Run Hive Simulation
217-
run: chmod +x hive && ./hive --client-file fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.simulation }} --sim.limit "${{ matrix.test_pattern }}" --sim.parallelism 16
217+
run: chmod +x hive && ./hive --client-file fixtures/network/hive_clients/ethrex.yml --client ethrex --sim ${{ matrix.simulation }} --sim.limit "${{ matrix.test_pattern }}" --sim.parallelism 16 --sim.loglevel 1
218218

219219
# The purpose of this job is to add it as a required check in GitHub so that we don't have to add every individual job as a required check
220220
all-tests:

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ setup-hive: ## 🐝 Set up Hive testing framework
106106
fi
107107

108108
TEST_PATTERN ?= /
109-
SIM_LOG_LEVEL ?= 1
109+
SIM_LOG_LEVEL ?= 3
110110
SIM_PARALLELISM ?= 16
111111

112112
# Runs a hive testing suite and opens an web interface on http://127.0.0.1:8080

0 commit comments

Comments
 (0)