-
Notifications
You must be signed in to change notification settings - Fork 164
feat: Virtual values as a OneOf in protobuf schema #20317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Virtual values as a OneOf in protobuf schema #20317
Conversation
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/StateUtils.java
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/StateUtils.java
Outdated
Show resolved
Hide resolved
...rm-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/disk/OnDiskQueueHelper.java
Outdated
Show resolved
Hide resolved
...dk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/disk/OnDiskReadableKVState.java
Outdated
Show resolved
Hide resolved
...dk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/disk/OnDiskSingletonHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
...rm-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/disk/OnDiskQueueHelper.java
Outdated
Show resolved
Hide resolved
...swirlds-state-impl/src/main/java/com/swirlds/state/merkle/disk/OnDiskWritableQueueState.java
Outdated
Show resolved
Hide resolved
...-state-impl/src/testFixtures/java/com/swirlds/state/test/fixtures/merkle/MerkleTestBase.java
Show resolved
Hide resolved
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/platform/state/virtual_map_state.proto
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/StateUtils.java
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/StateUtils.java
Outdated
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/MerkleStateRoot.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @thenswan !
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/MerkleStateRoot.java
Show resolved
Hide resolved
...node/hedera-app/src/test/java/com/hedera/node/app/state/merkle/MerkleSchemaRegistryTest.java
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/VirtualMapState.java
Show resolved
Hide resolved
platform-sdk/swirlds-state-impl/src/main/java/com/swirlds/state/merkle/queue/QueueState.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with a few comments/questions but none blocking
Description:
This PR changes Virtual Values, so they are represented as a OneOf in protobuf schema, hence changes in
virtual_map_state.proto
:VirtualLeaf
;QueueState
;VirtualMapValue
;:app:run
).Related issue(s):
Fixes #20288
Checklist