Skip to content

feat: update state validation tool to be compatible with the Mega Map #20319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025

Conversation

thenswan
Copy link
Contributor

Description:
This PR updates the state validation tool to be compatible with the Mega Map. It also cleans up redundant code after such an update.

Related issue(s):
Fixes #19412

Test
Only tested on a Mega Map state, which Tom generated in a longevity test.

Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@thenswan thenswan requested a review from a team as a code owner July 23, 2025 15:46
@thenswan thenswan requested a review from artemananiev July 23, 2025 15:47
@lfdt-bot
Copy link

lfdt-bot commented Jul 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Jul 23, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.16% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dbd6e7b) 102408 76703 74.90%
Head commit (744f866) 101780 (-628) 76397 (-306) 75.06% (+0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#20319) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #20319      +/-   ##
============================================
+ Coverage     70.99%   71.16%   +0.16%     
+ Complexity    24090    24018      -72     
============================================
  Files          2657     2646      -11     
  Lines        102503   101926     -577     
  Branches      10614    10557      -57     
============================================
- Hits          72775    72531     -244     
+ Misses        25755    25444     -311     
+ Partials       3973     3951      -22     
Files with missing lines Coverage Δ Complexity Δ
...main/java/com/swirlds/state/merkle/StateUtils.java 80.76% <100.00%> (+0.18%) 84.00 <1.00> (+1.00)
.../com/swirlds/state/merkle/disk/OnDiskIterator.java 84.00% <100.00%> (ø) 7.00 <0.00> (ø)

... and 48 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@thenswan
Copy link
Contributor Author

It's on hold till #20317 is merged. Then, this PR should be updated again, and only after it, merged.

Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
@artemananiev artemananiev requested a review from imalygin July 28, 2025 23:56
@artemananiev artemananiev added the Hedera State Validator Issues related to the hedera state validator label Jul 29, 2025
Copy link
Contributor

@OlegMazurov OlegMazurov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validator kills the consensus node if run in parallel. One testing scenario depends on that.

@OlegMazurov OlegMazurov self-requested a review July 29, 2025 01:54
@thenswan thenswan merged commit 34c268b into main Jul 29, 2025
80 of 82 checks passed
@thenswan thenswan deleted the 19412-update-state-validation-tool-for-vmm branch July 29, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera State Validator Issues related to the hedera state validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update State Validation Tool for Virtual Mega Map
5 participants