-
Notifications
You must be signed in to change notification settings - Fork 164
feat: update state validation tool to be compatible with the Mega Map #20319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20319 +/- ##
============================================
+ Coverage 70.99% 71.16% +0.16%
+ Complexity 24090 24018 -72
============================================
Files 2657 2646 -11
Lines 102503 101926 -577
Branches 10614 10557 -57
============================================
- Hits 72775 72531 -244
+ Misses 25755 25444 -311
+ Partials 3973 3951 -22
... and 48 files with indirect coverage changes 🚀 New features to boost your workflow:
|
...ator/src/main/java/com/hedera/statevalidation/validators/servicesstate/AccountValidator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
It's on hold till #20317 is merged. Then, this PR should be updated again, and only after it, merged. |
...ra-state-validator/src/main/java/com/hedera/statevalidation/parameterresolver/InitUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validator kills the consensus node if run in parallel. One testing scenario depends on that.
Description:
This PR updates the state validation tool to be compatible with the Mega Map. It also cleans up redundant code after such an update.
Related issue(s):
Fixes #19412
Test
Only tested on a Mega Map state, which Tom generated in a longevity test.