[audit-12] Fix Recommendations. #1209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-12-R-part-I
branch
from
5aadaeb to
62b61d6
Compare
[audit-12] Fix Recommendations.
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-12-R-part-I
branch
from
1170b6a to
fb71b75
Compare
matiasedgeandnode
requested review from
Maikol,
Copilot,
pcarranzav and
tmigone
and removed request for
Copilot
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
pcarranzav
approved these changes
Jul 31, 2025
| @@ -577,7 +579,7 @@ library IndexingAgreement { | |||
| agreementId: params.agreementId, | |||
| collectionId: bytes32(uint256(uint160(wrapper.agreement.allocationId))), | |||
| tokens: expectedTokens, | |||
| dataServiceCut: 0, | |||
| dataServiceCut: params.indexingFeesCut, | |||
There was a problem hiding this comment.
This will send the cut to the subgraph service contract, which would require a contract update for those funds to be used/transferred, right? (Not a problem per se, but maybe worth documenting)
There was a problem hiding this comment.
hmmm... I believe this mimics what's done for query fees. Is that the case for query fees as well?
There was a problem hiding this comment.
With query fees all of the data service fees are redistributed (as curation fees)
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-11-L-9
branch
from
dbe49d5 to
9423bfa
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-12-R-part-I
branch
from
fb71b75 to
f45f407
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-11-L-9
branch
from
9423bfa to
17b794e
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-12-R-part-I
branch
from
f45f407 to
b492251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.