fix: [TRST-R-6] Configurable indexing fees cut

Author: matiasedgeandnode

packages/subgraph-service/contracts/SubgraphService.sol

@@ -398,6 +398,13 @@ contract SubgraphService is
         emit CurationCutSet(curationCut);
     }
 
+    /// @inheritdoc ISubgraphService
+    function setIndexingFeesCut(uint256 indexingFeesCut_) external override onlyOwner {
+        require(PPMMath.isValidPPM(indexingFeesCut_), SubgraphServiceInvalidIndexingFeesCut(indexingFeesCut_));
+        indexingFeesCut = indexingFeesCut_;
+        emit IndexingFeesCutSet(indexingFeesCut_);
+    }
+
     /**
      * @inheritdoc ISubgraphService
      * @notice Accept an indexing agreement.
@@ -793,7 +800,8 @@ contract SubgraphService is
                 agreementId: _agreementId,
                 currentEpoch: _graphEpochManager().currentEpoch(),
                 receiverDestination: _paymentsDestination,
-                data: _data
+                data: _data,
+                indexingFeesCut: indexingFeesCut
             })
         );
 

packages/subgraph-service/contracts/SubgraphServiceStorage.sol

@@ -21,4 +21,7 @@ abstract contract SubgraphServiceV1Storage {
 
     /// @notice Destination of indexer payments
     mapping(address indexer => address destination) public paymentsDestination;
+
+    /// @notice The cut data service takes from indexing fee payments. In PPM.
+    uint256 public indexingFeesCut;
 }

packages/subgraph-service/contracts/interfaces/ISubgraphService.sol

@@ -69,12 +69,24 @@ interface ISubgraphService is IDataServiceFees {
      */
     event CurationCutSet(uint256 curationCut);
 
+    /**
+     * @notice Emitted when indexing fees cut is set
+     * @param indexingFeesCut The indexing fees cut
+     */
+    event IndexingFeesCutSet(uint256 indexingFeesCut);
+
     /**
      * @notice Thrown when trying to set a curation cut that is not a valid PPM value
      * @param curationCut The curation cut value
      */
     error SubgraphServiceInvalidCurationCut(uint256 curationCut);
 
+    /**
+     * @notice Thrown when trying to set an indexing fees cut that is not a valid PPM value
+     * @param indexingFeesCut The indexing fees cut value
+     */
+    error SubgraphServiceInvalidIndexingFeesCut(uint256 indexingFeesCut);
+
     /**
      * @notice Thrown when an indexer tries to register with an empty URL
      */
@@ -252,6 +264,13 @@ interface ISubgraphService is IDataServiceFees {
      */
     function setCurationCut(uint256 curationCut) external;
 
+    /**
+     * @notice Sets the data service payment cut for indexing fees
+     * @dev Emits a {IndexingFeesCutSet} event
+     * @param indexingFeesCut The indexing fees cut for the payment type
+     */
+    function setIndexingFeesCut(uint256 indexingFeesCut) external;
+
     /**
      * @notice Sets the payments destination for an indexer to receive payments
      * @dev Emits a {PaymentsDestinationSet} event

packages/subgraph-service/contracts/libraries/IndexingAgreement.sol

@@ -80,13 +80,15 @@ library IndexingAgreement {
      * @param currentEpoch The current epoch
      * @param receiverDestination The address where the collected fees should be sent
      * @param data The encoded data containing the number of entities indexed, proof of indexing, and epoch
+     * @param indexingFeesCut The indexing fees cut in PPM
      */
     struct CollectParams {
         address indexer;
         bytes16 agreementId;
         uint256 currentEpoch;
         address receiverDestination;
         bytes data;
+        uint256 indexingFeesCut;
     }
 
     /**
@@ -577,7 +579,7 @@ library IndexingAgreement {
                     agreementId: params.agreementId,
                     collectionId: bytes32(uint256(uint160(wrapper.agreement.allocationId))),
                     tokens: expectedTokens,
-                    dataServiceCut: 0,
+                    dataServiceCut: params.indexingFeesCut,
                     receiverDestination: params.receiverDestination,
                     maxSlippage: data.maxSlippage
                 })