-
Notifications
You must be signed in to change notification settings - Fork 561
refact(ci): merge Hstore CI with server ci #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tsukilc
wants to merge
7
commits into
apache:master
Choose a base branch
from
Tsukilc:refactor/merge-store
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−77
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ad235e6
refactor(ci): merge hstore with server
Tsukilc 687b248
refactor(ci): merge hstore with server
Tsukilc 76549ad
refactor(ci): avoid repeated compilation
Tsukilc dac88a8
refactor(ci): add prepare-backend.sh for prepare backend unique envir…
Tsukilc 38a9abd
refactor(ci): fix path
Tsukilc 584d151
refactor(ci): fix repeated step
Tsukilc f7db28f
format
Tsukilc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#!/bin/bash | ||
# This script prepares the backend CI environment based on the specified backend type. | ||
# It handles special build requirements for specific backends before invoking the | ||
# standard installation script. | ||
# | ||
# Usage: prepare-backend.sh <backend_type> | ||
# where <backend_type> is one of: memory, rocksdb, hbase, hstore, etc. | ||
set -e | ||
|
||
BACKEND=$1 | ||
|
||
echo "Preparing backend ci environment for $BACKEND..." | ||
|
||
if [[ "$BACKEND" == "hstore" ]]; then | ||
mvn package -U -Dmaven.javadoc.skip=true -Dmaven.test.skip=true -ntp | ||
Tsukilc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
fi | ||
|
||
$TRAVIS_DIR/install-backend.sh $BACKEND | ||
jps -l |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,13 +21,13 @@ jobs: | |
HEAD_BRANCH_NAME: ${{ github.head_ref }} | ||
BASE_BRANCH_NAME: ${{ github.base_ref }} | ||
TARGET_BRANCH_NAME: ${{ github.base_ref != '' && github.base_ref || github.ref_name }} | ||
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') || startsWith(github.ref_name, 'test-') }} | ||
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') || startsWith(github.ref_name, 'test-') || startsWith(github.base_ref, 'release-') }} | ||
RAFT_MODE: ${{ startsWith(github.head_ref, 'test') || startsWith(github.head_ref, 'raft') }} | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
BACKEND: [ memory, rocksdb, hbase ] | ||
BACKEND: [ memory, rocksdb, hbase, hstore ] | ||
JAVA_VERSION: [ '11' ] | ||
|
||
steps: | ||
|
@@ -43,10 +43,6 @@ jobs: | |
java-version: '8' | ||
distribution: 'zulu' | ||
|
||
- name: Prepare backend environment | ||
run: | | ||
$TRAVIS_DIR/install-backend.sh $BACKEND && jps -l | ||
|
||
Comment on lines
-46
to
-49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. WARN: Be careful, the order is important due to HBase 2.x used java8 (maybe we could upgrade it to Java11 |
||
- name: Install Java ${{ matrix.JAVA_VERSION }} | ||
uses: actions/setup-java@v4 | ||
with: | ||
|
@@ -70,6 +66,10 @@ jobs: | |
run: | | ||
mvn clean compile -U -Dmaven.javadoc.skip=true -ntp | ||
|
||
- name: Prepare backend unique environment | ||
run: | | ||
bash .github/scripts/prepare-backend.sh $BACKEND | ||
|
||
- name: Run unit test | ||
run: | | ||
$TRAVIS_DIR/run-unit-test.sh $BACKEND | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.