-
Notifications
You must be signed in to change notification settings - Fork 561
refact(ci): merge Hstore CI with server ci #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2789 +/- ##
============================================
- Coverage 41.16% 34.37% -6.80%
- Complexity 333 375 +42
============================================
Files 747 747
Lines 60123 60123
Branches 7676 7676
============================================
- Hits 24750 20665 -4085
- Misses 32793 37172 +4379
+ Partials 2580 2286 -294 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates the CI configuration by merging the Hstore CI into the existing server CI workflow and removing the dedicated hstore CI job from the pd-store CI workflow.
- Updated the RELEASE_BRANCH condition and BACKEND matrix in server-ci.yml to include Hstore
- Added a conditional packaging step for Hstore in server-ci.yml
- Removed the dedicated Hstore job block from pd-store-ci.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/server-ci.yml | Added Hstore to the BACKEND matrix, updated RELEASE_BRANCH condition, and included a conditional packaging step for Hstore |
.github/workflows/pd-store-ci.yml | Renamed workflow and removed the dedicated Hstore job block |
Comments suppressed due to low confidence (2)
.github/workflows/pd-store-ci.yml:1
- Ensure that the renaming of the workflow and the removal of the dedicated Hstore job are documented in your release notes or developer guides to avoid potential confusion.
name: "HugeGraph-PD & Store CI"
.github/workflows/pd-store-ci.yml:146
- Verify that the removal of the dedicated Hstore job does not leave any gaps in Hstore test coverage and that all necessary tests are now executed via the server-ci workflow.
Removed hstore job block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR centralizes HStore CI into the existing server CI workflow and removes the now-redundant HStore job from the PD/Store workflow.
- Add
hstore
to theserver-ci
matrix and refineRELEASE_BRANCH
logic - Remove the duplicated HStore job from
pd-store-ci.yml
and update workflow name - Introduce
prepare-backend.sh
to encapsulate backend setup for HStore
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
.github/workflows/server-ci.yml | Included hstore in BACKEND matrix, enhanced RELEASE_BRANCH expression, replaced inline setup with shared script |
.github/workflows/pd-store-ci.yml | Dropped the standalone HStore job and simplified workflow name |
.github/scripts/prepare-backend.sh | New script to handle backend preparation (HStore packaging and install-backend call) |
Comments suppressed due to low confidence (2)
.github/workflows/server-ci.yml:69
- [nitpick] The step name is generic; consider renaming it to something like
Prepare HStore backend environment
to clarify that it only applies special setup for the HStore backend.
- name: Prepare backend unique environment
.github/scripts/prepare-backend.sh:1
- [nitpick] The script lacks a header comment explaining its purpose and usage. Adding a brief description at the top will help future maintainers understand why it exists.
#!/bin/bash
- name: Prepare backend environment | ||
run: | | ||
$TRAVIS_DIR/install-backend.sh $BACKEND && jps -l | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARN: Be careful, the order is important due to HBase 2.x used java8 (maybe we could upgrade it to Java11
compatible version)
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
Purpose of the PR
merge Hstore CI with server ci ,The server contains the tests of the other three stores. Now add hstore as well to reuse the code
ci result in Tsukilc#3
sub task of [#2724](#2764)
Are there any pre-processing/post-processing tasks for this task that are convenient to handle incidentally? I can deal with it.
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need