-
Notifications
You must be signed in to change notification settings - Fork 28
refactor(specs): re-organise response for Composition API #5744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+180
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
f8dbca1 to
0618bd7
Compare
0618bd7 to
e7fa7f4
Compare
gavinwade12
reviewed
Dec 15, 2025
specs/composition/common/schemas/responses/runResponseComponents/CompositionsRunSection.yml
Show resolved
Hide resolved
specs/composition/common/schemas/responses/runResponseComponents/CompositionsRunSection.yml
Show resolved
Hide resolved
gavinwade12
approved these changes
Dec 15, 2025
Fluf22
approved these changes
Dec 16, 2025
algolia-bot
added a commit
that referenced
this pull request
Dec 16, 2025
…nerated) [skip ci] Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Dec 16, 2025
algolia/api-clients-automation#5744 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: planning for https://algolia.atlassian.net/browse/CMP-625
No functional changes, only re-organisation
Changes included:
Create file
specs/composition/common/schemas/responses/runResponseComponents/CompositionsRunSection.ymlto gather component related to thecompositionssection of the run resultcompositionBaseSearchResponse,compositionsSearchResponse,compositionRunSearchResponsecompositionRunAppliedRulesAdd payload example to clarify which file targets which section
Gather
SearchPagination&SearchPagination(initially raw copy paste from Search API) intoSearchFields🧪 Test
CI