fix: searchable field values #53
Conversation
WalkthroughThe changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/api/src/modules/summary/summary.service.ts (1 hunks)
Additional comments not posted (1)
apps/api/src/modules/summary/summary.service.ts (1)
86-86: LGTM! But verify the database schema.The
searchableFieldsarray has been updated to includeinputFileandoutputText, replacingdataandresult. Ensure that the new fields are correctly indexed and available in the database schema to avoid any potential issues during queries.The code changes are approved.
Run the following script to verify the database schema:
Verification successful
Fields
inputFileandoutputTextare correctly integrated into the database schema.The fields
inputFileandoutputTextare present in the entity definitions and are used throughout the application, confirming their integration into the database schema and application logic. No further action is required.
- Found in
apps/api/src/modules/summary/entities/summary.entity.ts- Used in
apps/api/src/modules/summary/dto/create-summary.dto.ts- Utilized in
apps/api/src/modules/summary/summary.service.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new fields `inputFile` and `outputText` are indexed and available in the database schema. # Test: Search for the new fields in the database schema. Expect: Fields are indexed and available. rg --type sql -A 5 $'inputFile|outputText'Length of output: 192
Script:
#!/bin/bash # Locate potential ORM model or migration files and search for `inputFile` and `outputText`. # Find files that might contain schema definitions, such as ORM models or migrations. fd --type f --extension ts --extension js --extension json --extension yml --extension yaml --extension sql # Search for the fields `inputFile` and `outputText` in the located files. rg 'inputFile|outputText' $(fd --type f --extension ts --extension js --extension json --extension yml --extension yaml --extension sql)Length of output: 9444
API PR Checklist
Pre-requisites
PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint)Additional Information
ready for reviewshould be added if the PR is ready to be reviewed)Description:
Update searchable fields list so that we can use GraphQL search property
Related changes:
data,resultcolumns{ "errors": [ { "message": "Unknown column 'summary.data' in 'where clause'", "locations": [ { "line": 2, "column": 3 } ], "path": [ "summaries" ], "extensions": { "code": "INTERNAL_SERVER_ERROR", "stacktrace": [ "QueryFailedError: Unknown column 'summary.data' in 'where clause'", " at Query.onResult (osm-transcript-summarizer/apps/api/node_modules/typeorm/driver/src/driver/mysql/MysqlQueryRunner.ts:246:33)", " at Query.execute (osm-transcript-summarizer/apps/api/node_modules/mysql2/lib/commands/command.js:36:14)", " at PoolConnection.handlePacket (osm-transcript-summarizer/apps/api/node_modules/mysql2/lib/connection.js:481:34)", " at PacketParser.onPacket (osm-transcript-summarizer/apps/api/node_modules/mysql2/lib/connection.js:97:12)", " at PacketParser.executeStart (osm-transcript-summarizer/apps/api/node_modules/mysql2/lib/packet_parser.js:75:16)", " at Socket.<anonymous> (osm-transcript-summarizer/apps/api/node_modules/mysql2/lib/connection.js:104:25)", " at Socket.emit (node:events:519:28)", " at addChunk (node:internal/streams/readable:559:12)", " at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)", " at Readable.push (node:internal/streams/readable:390:5)" ] } } ], "data": null }Screenshots:
NA
Query request and response:
NA
Documentation changes:
NA
Test suite output:
NA
Pending actions:
NA
Additional notes:
NA
Summary by CodeRabbit
New Features
inputFileandoutputTextattributes, enhancing the relevance of search results.Bug Fixes
findAllmethod retrieves data based on the new searchable fields without affecting overall performance.