Skip to content

docs: add api documentation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2024
Merged

docs: add api documentation #50

merged 6 commits into from
Sep 2, 2024

Conversation

kshitij-k-osmosys
Copy link
Contributor

@kshitij-k-osmosys kshitij-k-osmosys commented Aug 22, 2024

API PR Checklist

Pre-requisites

  • I have gone through the Contributing guidelines for Submitting a Pull Request (PR) and ensured that this is not a duplicate PR.
  • I have performed preliminary unit testing.
  • I have updated the required api docs as applicable.
  • I have added/updated test cases to the test suite as applicable

PR Details

PR details have been updated as per the given format (see below)

  • PR title adheres to the format specified in guidelines (e.g., feat: add admin login endpoint)
  • Description has been added
  • Related changes have been added (optional)
  • Screenshots have been added (optional)
  • Query request and response examples have been added (as applicable, in case added or updated)
  • Documentation changes have been listed (as applicable)
  • Test suite output is added (as applicable)
  • Pending actions have been added (optional)
  • Any other additional notes have been added (optional)

Additional Information

  • Appropriate label(s) have been added (ready for review should be added if the PR is ready to be reviewed)
  • Assignee(s) and reviewer(s) have been added (optional)

Description:

  • Create api documentation
  • Update postman collection
  • Update searchable fields to allow searching on the following fields: inputFile, createdBy, outputText

Related changes:

NA

Screenshots:

NA

Query request and response:

NA

Documentation changes:

Update existing postman collection with scripts and description as well as dummy data

Test suite output:

NA

Pending actions:

NA

Additional notes:

NA

Summary by CodeRabbit

  • New Features

    • Enhanced Postman collection for the "Transcript Summarization" API with clearer request structures and improved test cases.
    • Comprehensive API documentation added, detailing file upload and summary retrieval functionalities.
  • Bug Fixes

    • Improved error handling and validation for API responses.
  • Refactor

    • Updated searchable fields in the summary service to better align with current business requirements.

@kshitij-k-osmosys kshitij-k-osmosys self-assigned this Aug 22, 2024
Copy link
Contributor

coderabbitai bot commented Aug 22, 2024

Walkthrough

The updates encompass significant modifications to the "Transcript Summarization" API, including changes to the Postman collection, enhancements to API documentation, and adjustments to the summary service's search functionality. Key alterations include revised request structures, expanded test cases, and a refined searchable fields array, reflecting an improved focus on relevant attributes for job summaries.

Changes

Files Change Summary
apps/api/Transcript Summarization.postman_collection.json Updated Postman collection with new ID, description, schema version, refined request structures, improved test cases, and enhanced security practices.
apps/api/docs/api-documentation.md Introduced comprehensive API documentation detailing file upload and fetching summaries, including request structures, examples, and expected responses.
apps/api/src/modules/summary/summary.service.ts Modified searchableFields in SummaryService, replacing data and result with inputFile and outputText.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant API
    participant Service

    User->>API: Upload Transcript File
    API->>Service: Process File Upload
    Service-->>API: Return Success Response
    API-->>User: Provide Upload Result
Loading

🐇 Hop, hop, hooray! New features we display,
With fields refined and tests aligned,
Our APIs shine bright, ready for the day!
So let's bounce along, with joy and cheer,
For every change brings progress near! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kshitij-k-osmosys kshitij-k-osmosys linked an issue Aug 25, 2024 that may be closed by this pull request
@kshitij-k-osmosys kshitij-k-osmosys added documentation Improvements or additions to documentation Ready for review Ready for review labels Aug 25, 2024
@kshitij-k-osmosys kshitij-k-osmosys marked this pull request as ready for review August 25, 2024 08:46
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
apps/api/docs/api-documentation.md (1)

1-158: Comprehensive and well-structured API documentation.

The documentation provides clear and detailed instructions for interacting with the API, enhancing usability and developer experience.

Consider addressing the style issues suggested by LanguageTool and Markdownlint to improve readability and maintain consistency.

Tools
LanguageTool

[style] ~18-~18: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...the original media type of the resource prior to any content encoding applied before tra...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[style] ~19-~19: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...es, expressed as MIME types, the client is able to understand | | Connection | keep-alive ...

(BE_ABLE_TO)


[uncategorized] ~20-~20: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... be used to set a timeout and a maximum amount of requests | | Authorization | Bearer ...

(AMOUNTOF_TO_NUMBEROF)


[style] ~81-~81: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...the original media type of the resource prior to any content encoding applied before tra...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[style] ~82-~82: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...es, expressed as MIME types, the client is able to understand | | Connection | keep-alive ...

(BE_ABLE_TO)


[uncategorized] ~83-~83: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... be used to set a timeout and a maximum amount of requests | | Authorization | Bearer ...

(AMOUNTOF_TO_NUMBEROF)

Markdownlint

32-32: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


47-47: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


121-121: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


133-133: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f48676 and 6d4fe66.

Files selected for processing (3)
  • apps/api/Transcript Summarization.postman_collection.json (2 hunks)
  • apps/api/docs/api-documentation.md (1 hunks)
  • apps/api/src/modules/summary/summary.service.ts (1 hunks)
Additional context used
LanguageTool
apps/api/docs/api-documentation.md

[style] ~18-~18: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...the original media type of the resource prior to any content encoding applied before tra...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[style] ~19-~19: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...es, expressed as MIME types, the client is able to understand | | Connection | keep-alive ...

(BE_ABLE_TO)


[uncategorized] ~20-~20: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... be used to set a timeout and a maximum amount of requests | | Authorization | Bearer ...

(AMOUNTOF_TO_NUMBEROF)


[style] ~81-~81: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...the original media type of the resource prior to any content encoding applied before tra...

(EN_WORDINESS_PREMIUM_PRIOR_TO)


[style] ~82-~82: As a shorter alternative for ‘able to’, consider using “can”.
Context: ...es, expressed as MIME types, the client is able to understand | | Connection | keep-alive ...

(BE_ABLE_TO)


[uncategorized] ~83-~83: ‘Amount of’ should usually only be used with uncountable or mass nouns. Consider using “number” if this is not the case.
Context: ... be used to set a timeout and a maximum amount of requests | | Authorization | Bearer ...

(AMOUNTOF_TO_NUMBEROF)

Markdownlint
apps/api/docs/api-documentation.md

32-32: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


47-47: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


121-121: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


133-133: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Additional comments not posted (2)
apps/api/src/modules/summary/summary.service.ts (1)

86-86: Approved change in searchable fields.

The update to searchableFields is aligned with the new business requirements. Ensure that inputFile and outputText are indexed in the database for optimal search performance.

apps/api/Transcript Summarization.postman_collection.json (1)

Line range hint 3-424: Significant improvements to the Postman collection.

The updates enhance the clarity and robustness of the API testing framework. Ensure that the new test cases are integrated with the CI/CD pipeline for automated testing.

@xixas xixas merged commit 3e0647f into main Sep 2, 2024
6 checks passed
@xixas xixas deleted the docs/api-doc branch September 2, 2024 05:11
@coderabbitai coderabbitai bot mentioned this pull request Jun 17, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete TODO in api-documentation.md
2 participants