Skip to content

[AKS] az aks nodepool update: Add GPU driver install options install and none for --gpu-driver parameter #9472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilypan26 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[AKS] az aks nodepool update: Add GPU driver install options install and none for --gpu-driver parameter #9472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
773fbad
add gpu_driver option to nodepool update
lilypan26 Dec 12, 2025
4d8b4fc
update HISTORY.rst
lilypan26 Dec 12, 2025
e6797e8
add gpu_driver to agent update decorator
lilypan26 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

19.0.0b19
+++++++
* Add option `--gpu-driver` to `az aks nodepool update` to select skipping GPU driver installation.
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should more accurately reflect the functionality being added. Consider revising to: "Add option --gpu-driver to az aks nodepool update to control GPU driver installation with values 'Install' or 'None'." This is clearer than "to select skipping GPU driver installation" because the parameter supports both installing and skipping, not just skipping.

Suggested change
* Add option `--gpu-driver` to `az aks nodepool update` to select skipping GPU driver installation.
* Add option `--gpu-driver` to `az aks nodepool update` to control GPU driver installation with values 'Install' or 'None'.

Copilot uses AI. Check for mistakes.

19.0.0b18
+++++++
* Vendor new SDK and bump API version to 2025-10-02-preview.
Expand Down
4 changes: 4 additions & 0 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2129,6 +2129,10 @@ def load_arguments(self, _):
options_list=["--node-vm-size", "-s"],
completer=get_vm_size_completion_list,
)
c.argument(
"gpu_driver",
Copy link
Member

@FumingZhang FumingZhang Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you also need to declare this parameter in the entry function corresponding to the command, which is aks_agentpool_update in custom.py

arg_type=get_enum_type(gpu_driver_install_modes)
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpu_driver parameter is missing documentation. Add a help parameter to provide guidance to users, similar to line 1978. Based on the help text in _help.py line 2162, consider adding: help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'."

Suggested change
arg_type=get_enum_type(gpu_driver_install_modes)
arg_type=get_enum_type(gpu_driver_install_modes),
help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'."

Copilot uses AI. Check for mistakes.
)

with self.argument_context("aks nodepool upgrade") as c:
# upgrade strategy
Expand Down
1 change: 1 addition & 0 deletions src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,6 +1977,7 @@ def aks_agentpool_update(
# local DNS
localdns_config=None,
node_vm_size=None,
gpu_driver=None,
):
# DO NOT MOVE: get all the original parameters and save them as a dictionary
raw_parameters = locals()
Expand Down
Loading