-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] az aks nodepool update: Add GPU driver install options install and none for --gpu-driver parameter
#9472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks nodepool update | cmd aks nodepool update added parameter gpu_driver |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @lilypan26, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @lilypan26 Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the --gpu-driver parameter to the az aks nodepool update command to control GPU driver installation on node pools. The parameter accepts values "Install" or "None" to either install or skip GPU driver installation.
Key Changes:
- Added
gpu_driverparameter configuration toaz aks nodepool updatecommand in _params.py - Updated HISTORY.rst to document the new feature in version 19.0.0b19
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/_params.py | Adds gpu_driver parameter configuration to the aks nodepool update argument context using the existing gpu_driver_install_modes enum |
| src/aks-preview/HISTORY.rst | Documents the addition of --gpu-driver option to az aks nodepool update command in version 19.0.0b19 |
|
|
||
| 19.0.0b19 | ||
| +++++++ | ||
| * Add option `--gpu-driver` to `az aks nodepool update` to select skipping GPU driver installation. |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should more accurately reflect the functionality being added. Consider revising to: "Add option --gpu-driver to az aks nodepool update to control GPU driver installation with values 'Install' or 'None'." This is clearer than "to select skipping GPU driver installation" because the parameter supports both installing and skipping, not just skipping.
| * Add option `--gpu-driver` to `az aks nodepool update` to select skipping GPU driver installation. | |
| * Add option `--gpu-driver` to `az aks nodepool update` to control GPU driver installation with values 'Install' or 'None'. |
| ) | ||
| c.argument( | ||
| "gpu_driver", | ||
| arg_type=get_enum_type(gpu_driver_install_modes) |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gpu_driver parameter is missing documentation. Add a help parameter to provide guidance to users, similar to line 1978. Based on the help text in _help.py line 2162, consider adding: help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'."
| arg_type=get_enum_type(gpu_driver_install_modes) | |
| arg_type=get_enum_type(gpu_driver_install_modes), | |
| help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'." |
| completer=get_vm_size_completion_list, | ||
| ) | ||
| c.argument( | ||
| "gpu_driver", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you also need to declare this parameter in the entry function corresponding to the command, which is aks_agentpool_update in custom.py
|
please fix failed CI checks GH Azdev Linter / azdev-linter (pull_request_target)
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --gpu-driver noneGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.