Skip to content

Conversation

@lilypan26
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --gpu-driver none

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 12, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter gpu_driver

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-client-tools-bot-prd
Copy link

Hi @lilypan26,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Hi @lilypan26

Release Suggestions

Module: aks-preview

  • Update VERSION to 19.0.0b18 in src/aks-preview/setup.py

Notes

@lilypan26 lilypan26 marked this pull request as ready for review December 12, 2025 00:55
Copilot AI review requested due to automatic review settings December 12, 2025 00:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the --gpu-driver parameter to the az aks nodepool update command to control GPU driver installation on node pools. The parameter accepts values "Install" or "None" to either install or skip GPU driver installation.

Key Changes:

  • Added gpu_driver parameter configuration to az aks nodepool update command in _params.py
  • Updated HISTORY.rst to document the new feature in version 19.0.0b19

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/aks-preview/azext_aks_preview/_params.py Adds gpu_driver parameter configuration to the aks nodepool update argument context using the existing gpu_driver_install_modes enum
src/aks-preview/HISTORY.rst Documents the addition of --gpu-driver option to az aks nodepool update command in version 19.0.0b19


19.0.0b19
+++++++
* Add option `--gpu-driver` to `az aks nodepool update` to select skipping GPU driver installation.
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should more accurately reflect the functionality being added. Consider revising to: "Add option --gpu-driver to az aks nodepool update to control GPU driver installation with values 'Install' or 'None'." This is clearer than "to select skipping GPU driver installation" because the parameter supports both installing and skipping, not just skipping.

Suggested change
* Add option `--gpu-driver` to `az aks nodepool update` to select skipping GPU driver installation.
* Add option `--gpu-driver` to `az aks nodepool update` to control GPU driver installation with values 'Install' or 'None'.

Copilot uses AI. Check for mistakes.
)
c.argument(
"gpu_driver",
arg_type=get_enum_type(gpu_driver_install_modes)
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpu_driver parameter is missing documentation. Add a help parameter to provide guidance to users, similar to line 1978. Based on the help text in _help.py line 2162, consider adding: help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'."

Suggested change
arg_type=get_enum_type(gpu_driver_install_modes)
arg_type=get_enum_type(gpu_driver_install_modes),
help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'."

Copilot uses AI. Check for mistakes.
completer=get_vm_size_completion_list,
)
c.argument(
"gpu_driver",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you also need to declare this parameter in the entry function corresponding to the command, which is aks_agentpool_update in custom.py

@FumingZhang
Copy link
Member

please fix failed CI checks GH Azdev Linter / azdev-linter (pull_request_target)

  • FAIL - HIGH severity: missing_parameter_help
    Parameter: aks nodepool update, gpu_driver - Missing help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants