board: xhsc: hc32f4a0_evb: Add minimal supprot for hc32f4a0_evb board #94044

TrackingRobot · 2025-08-04T03:20:09Z

This commit adds support for the hc32f4a0_evb board to print info by usart, including the necessary devicetree files, Kconfig configurations, peripherals and board-specific documentation.

The following changes about the board are included:

Add hc32f4a0_evb.dts with hardware description for the board.
Add Kconfig.board and Kconfig.defconfig for default software configurations.
Add board documentation in doc/index.rst. - Add board.yaml for test runner metadata.

To implement console output, the following peripheral are supported:

gpio
intc
clock
serial

github-actions · 2025-08-04T03:21:54Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_xhsc 🆕	N/A (Added)	zephyrproject-rtos/hal_xhsc@`45f9eec` (`zephyr`)	N/A

⛔ DNM label due to: 1 added project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm · 2025-08-04T06:41:23Z

drivers/clock_control/Kconfig.hc32

+config CLOCK_CONTROL_HC32
+	bool "HC32 Clock Control"
+
+if CLOCK_CONTROL_HC32
+
+config HC32_LL_CLK
+	bool
+	default y


I have no clue what is going on here but no, fix properly and use proper dependency

That was defined in modules/Kconfig.xhsc, and its default value is 'y'. Therefore, I deleted lines 7 to 14 in this file.

nordicjm · 2025-08-04T06:41:34Z

drivers/clock_control/Kconfig.hc32

+	  Select High Driver for XTAL32
+
+config HC32_XTAL32_DRV_M
+	bool "medium Driver"


Capitalise first letter of prompt

nordicjm · 2025-08-04T06:41:42Z

drivers/clock_control/Kconfig.hc32

+	bool "medium Driver"
+	help
+	  Select medium Driver for XTAL32
+endchoice


newline missing on line 26

nordicjm · 2025-08-04T06:41:48Z

drivers/clock_control/Kconfig.hc32

+config HC32_XTAL32_DRV
+	int
+	default 0 if HC32_XTAL32_DRV_M
+	default 1 if HC32_XTAL32_DRV_H


what is this?

These options configure the drive current strength of the external low-speed crystal based on varying capacitances.

make them dts properties

nordicjm · 2025-08-04T06:42:36Z

drivers/serial/Kconfig.hc32

+	default y
+	depends on DT_HAS_XHSC_HC32_UART_ENABLED
+	select SERIAL_HAS_DRIVER
+    select HC32_LL_USART


tab not spaces for ident

nordicjm · 2025-08-04T06:48:41Z

boards/xhsc/hc32f4a0_evb/doc/board.jpg

file is way too huge, needs to be far smaller, then save as webp and put through https://tinypng.com/

Reduce the image file size from its original 716KB (1128x828, jpg) to a smaller size of 61KB (789x579, webp).

nordicjm · 2025-08-04T06:48:53Z

boards/xhsc/hc32f4a0_evb/doc/index.rst

+The board configuration supports the following hardware features:
+
+.. list-table::
+   :header-rows: 1
+
+   * - Peripheral
+     - Kconfig option
+     - Devicetree compatible
+   * - GPIO
+     - :kconfig:option:`CONFIG_GPIO`
+     - :dtcompatible:`xhsc,hc32-gpio`
+   * - NVIC
+     - N/A
+     - :dtcompatible:`arm,v7m-nvic`
+   * - PINMUX
+     - :kconfig:option:`CONFIG_PINCTRL`
+     - :dtcompatible:`xhsc,hc32-pinctrl`
+  * - USART
+     * - :kconfig:option:`CONFIG_SERIAL`
+     - :dtcompatible:`xhsc,hc32-uart`
+
+Other hardware features are not yet supported on this Zephyr port.


use hw directive tag

nordicjm · 2025-08-04T06:49:10Z

boards/xhsc/hc32f4a0_evb/hc32f4a0_evb_defconfig

+CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=240000000
+CONFIG_SYS_CLOCK_TICKS_PER_SEC=1000
+CONFIG_HC32_DDL_DEBUG=y


Suggested change

CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=240000000

CONFIG_SYS_CLOCK_TICKS_PER_SEC=1000

CONFIG_HC32_DDL_DEBUG=y

nordicjm · 2025-08-04T06:49:16Z

boards/xhsc/hc32f4a0_evb/hc32f4a0_evb_defconfig

+CONFIG_CONSOLE=y
+CONFIG_UART_CONSOLE=y
+CONFIG_SERIAL=y
+CONFIG_PINCTRL=y


Suggested change

CONFIG_PINCTRL=y

Moved to the soc/xhsc/hc32/hc32f4xx/Kconfig.

nordicjm · 2025-08-04T06:49:26Z

west.yml

+    - name: hal_xhsc
+      revision: 45f9eec3064663b992da9f1497aaaa8371bcb821
+      path: modules/hal/xhsc
+      groups:
+        - hal


this needs to come before things that need it

Hi @nordicjm,
May I ask, do you mean that we should first submit a PR for the manifest and MAINTAINERS files? After that pull request is merged, can we then submit the pull request for adding the board and SoC?
Or, do we simply need to adjust the commit sequence to move the manifest and MAINTAINERS to the first two commits?

TrackingRobot · 2025-08-04T09:37:31Z

Hi @nordicjm, thanks for your efficient checking and quick comments. Being new contributors, we made a lot of mistakes in the code. We will fix these bugs as soon as possible, and the fixed issues will be marked with a thumbs-up emoji!

…_xhsc. Add levizh as maintainers, add Pengbiao12345, ETRD, greya5, JamieTx, TrackingRobot as collaborators for hal_xhsc. Signed-off-by: TrackingRobot <code9527@126.com>

Add HAL repository information for the first supported HC32F4A0_EVB and HC32F460_EVB. Signed-off-by: TrackingRobot <code9527@126.com>

This is the initial commit to support clock_control driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

This is the initial commit to support gpio driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

This is the initial commit to support pinctrl driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

This is the initial commit to support interrupt controller Signed-off-by: TrackingRobot <code9527@126.com>

This is the initial commit to support USART driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

Add support for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

This adds minimal support for board HC32F4A0_EVB Signed-off-by: TrackingRobot <code9527@126.com>

sonarqubecloud · 2025-08-08T10:23:36Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

TrackingRobot · 2025-08-08T12:25:05Z

In order to maintain the cleanliness of the submission, we had to use rebase and force push.
We created a another branch to make the PR changes traceable:
https://github.com/levizh/zephyr/tree/xhsc-pr-fixup#

github-actions bot added the manifest label Aug 4, 2025

TrackingRobot force-pushed the xhsc-develop branch 2 times, most recently from 4fffc40 to d411de8 Compare August 4, 2025 06:28

nordicjm requested changes Aug 4, 2025

View reviewed changes

TrackingRobot added 9 commits August 8, 2025 17:47

MAINTAINERS: Add maintainers and collaborators for the hal module hal…

47949f9

…_xhsc. Add levizh as maintainers, add Pengbiao12345, ETRD, greya5, JamieTx, TrackingRobot as collaborators for hal_xhsc. Signed-off-by: TrackingRobot <code9527@126.com>

manifest: Add new member hal_xhsc of HAL group.

994dd2e

Add HAL repository information for the first supported HC32F4A0_EVB and HC32F460_EVB. Signed-off-by: TrackingRobot <code9527@126.com>

drivers: clock_control: Add support for HC32F4A0

31e1659

This is the initial commit to support clock_control driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

drivers: gpio: Add support for HC32F4A0

2b8c441

This is the initial commit to support gpio driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

drivers: pinctrl: Add support for HC32F4A0

fe1989b

This is the initial commit to support pinctrl driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

drivers: interrupt_controller: Add support for HC32F4A0

84dbbb6

This is the initial commit to support interrupt controller Signed-off-by: TrackingRobot <code9527@126.com>

drivers: serial: Add support for HC32F4A0

c0566b9

This is the initial commit to support USART driver for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

soc: xhsc: Add support for XHSC HC32F4A0

02aa901

Add support for XHSC HC32F4A0 Signed-off-by: TrackingRobot <code9527@126.com>

boards: xhsc: Add minimal support for board HC32F4A0_EVB

dc898cb

This adds minimal support for board HC32F4A0_EVB Signed-off-by: TrackingRobot <code9527@126.com>

TrackingRobot force-pushed the xhsc-develop branch from bafafbc to dc898cb Compare August 8, 2025 10:07

	CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=240000000
	CONFIG_SYS_CLOCK_TICKS_PER_SEC=1000
	CONFIG_HC32_DDL_DEBUG=y

board: xhsc: hc32f4a0_evb: Add minimal supprot for hc32f4a0_evb board #94044

Are you sure you want to change the base?

board: xhsc: hc32f4a0_evb: Add minimal supprot for hc32f4a0_evb board #94044

Conversation

TrackingRobot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TrackingRobot Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TrackingRobot commented Aug 4, 2025

Uh oh!

sonarqubecloud bot commented Aug 8, 2025

Quality Gate passed

Uh oh!

TrackingRobot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 4, 2025 •

edited

Loading

TrackingRobot Aug 5, 2025 •

edited

Loading

TrackingRobot commented Aug 8, 2025 •

edited

Loading