x86: fix issue when allocating 1 vector via MSI-X #93462
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qemu_x86_64 has NVME disk as overlay so we need to enable kconfig CONFIG_NVME or else it would fail to compile. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
arch_pcie_msi_vectors_allocate() has a return type of uint8_t. One of the error path returns -1 which would result in 255 being returned. So fix that by returning 0 instead, as there is no vector being allocated anyway. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Fix an issue where 1 vector is being requested when MSI-X is enabled. The previous logic always assumed the PCIE device has only fixed or single MSI when we are requesting 1 vector, which is not entirely correct. So if there is no vector allocated already, try to allocate one. Fixes zephyrproject-rtos#93319 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
1 task
1 task
|
zephyrbot
requested review from
andyross,
ceolin,
danieldegrasse,
decsny,
edersondisouza,
jfischer-no,
laurenmurphyx64 and
nashif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arch_pcie_msi_vectors_allocate()tests/drivers/disk/disk_performaceforqemu_x86_64.