manifest: another batch of optional -> external modules #93383
Conversation
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
kartben,
MaureenHelm,
parthitce and
stephanosio
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 2 removed projects Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-lz4
manifest-zscilib
DNM (manifest)
nashif
force-pushed
the
topic/manifest/optional
branch
from
55055db to
ebeb05c
Compare
nashif
changed the title
nashif
force-pushed
the
topic/manifest/optional
branch
4 times, most recently
from
d1f0ae2 to
e1e3466
Compare
| @@ -5534,16 +5534,6 @@ West: | |||
| labels: | |||
| - "area: LVGL" | |||
|
|
|||
| "West project: lz4": | |||
There was a problem hiding this comment.
Commit message didn't say "WHY". May I know the context here?
west.yml
Outdated
| group-filter: [-babblesim, -optional, -testing]] | ||
| group-filter: [-babblesim, -optional, -testing] |
There was a problem hiding this comment.
looks like this should have been squashed in the first commit
nashif
force-pushed
the
topic/manifest/optional
branch
from
e1e3466 to
728e322
Compare
Those tests are needed for verifying and testing tf-m. While not needed directly by zephyr, they are needed for testing and CI. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Tests needed to verify tf-a module. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
We need the tests in CI to be able to run them on supported platforms. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Remove from manifest and make it an external module. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Move lz4 to become external module. It is not in the default manifest anymore (through submanifests) and will need to be added if application requires it per the docs. Samples will be moved to the module itself. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/manifest/optional
branch
from
728e322 to
b8404e9
Compare
|
| projects: | ||
| - name: lz4 | ||
| url: https://github.com/zephyrproject-rtos/lz4 | ||
| revision: main |
There was a problem hiding this comment.
| revision: main | |
| revision: zephyr |
| projects: | ||
| - name: zscilib- | ||
| url: https://github.com/zephyrproject-rtos/zscilib | ||
| revision: main |
There was a problem hiding this comment.
We should probably rename the branch to main - I think GitHub handles this fully transparently, right? Meanwhile:
| revision: main | |
| revision: master |
| Be sure to run source zephyr/zephyr-env.sh (OS X or Linux) or | ||
| .\zephyr\zephyr-env.cmd (Windows) before the commands below! | ||
| This also assumes qemu-system-arm is available on your local system. | ||
|
|
There was a problem hiding this comment.
I think it's safe to drop -- this was probably useful recommendations several years ago but probably not really useful anymore.
In fact, do you want to completely drop "Running a sample application" and "Running Unit Tests" section? At line 33-34 you're already sending people to the project's repo for more info, I think that's enough.
| Be sure to run source zephyr/zephyr-env.sh (OS X or Linux) or | |
| .\zephyr\zephyr-env.cmd (Windows) before the commands below! | |
| This also assumes qemu-system-arm is available on your local system. |
| https://github.com/lz4/lz4/tree/dev/doc | ||
|
|
||
| .. _lz4 examples: | ||
| https://github.com/zephyrproject-rtos/lz4/tree/zephyr/zephyr/samples |
There was a problem hiding this comment.
this path doesn't exist - guess you want https://github.com/zephyrproject-rtos/lz4/tree/zephyr/examples
But I guess it would be nice to move the sample you're deleting in this PR to the lz4 repo, so that there is an actual "zephyr" sample. I'll make a PR
There was a problem hiding this comment.
zephyrproject-rtos/lz4#3
So that link should actually work once merged
Part of #91061