Request cacheability follow the spec #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-j
force-pushed
the
feat/mock-cache-accept-only-cacheable
branch
3 times, most recently
from
3cd3cc0 to
a87094d
Compare
p-j
force-pushed
the
feat/mock-cache-accept-only-cacheable
branch
from
a87094d to
ad2a119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant spec part: https://w3c.github.io/ServiceWorker/#cache-addAll
Not all requests can be added to the cache, only GET over HTTP or HTTPS can be.
This PR add a function to check for the "cacheability" of a request and throw the appropriate error if not.
I've added tests for this PR but I haven't fixed the already broken ones.