-
Notifications
You must be signed in to change notification settings - Fork 702
Fix usage of storage until alter the topic #21515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 The changelog entry is less than 20 characters or missing. |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Не очень понял, в чем проблема (в описание бы).
- Багфикс без теста выглядит странно.
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
Если создать топик без резерва места (в лимите на БД используется фактически занятое сообщениями из топика место), а потом сменить тип топика на "резервировать место" (будет использоваться место "время хранения сообщений" * "скорость записи в топик"), то неправильно проверяется сколько дополнительно места надо в БД что бы можно было изменить тип.
Сейчас проверяется, что в БД должно быть свободно "время хранения сообщений" * "скорость записи в топик"
Надо что бы проверялось "время хранения сообщений" * "скорость записи в топик" - "уже используется сообщениями топика"