Skip to content

Fix usage of storage until alter the topic #21515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025

Conversation

nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Jul 22, 2025

Changelog entry

...

Changelog category

  • Bugfix

Description for reviewers

Если создать топик без резерва места (в лимите на БД используется фактически занятое сообщениями из топика место), а потом сменить тип топика на "резервировать место" (будет использоваться место "время хранения сообщений" * "скорость записи в топик"), то неправильно проверяется сколько дополнительно места надо в БД что бы можно было изменить тип.
Сейчас проверяется, что в БД должно быть свободно "время хранения сообщений" * "скорость записи в топик"
Надо что бы проверялось "время хранения сообщений" * "скорость записи в топик" - "уже используется сообщениями топика"

@nshestakov nshestakov requested a review from a team as a code owner July 22, 2025 17:51
@nshestakov nshestakov changed the title Fix usage of storage until alter topic Fix usage of storage until alter the topic Jul 22, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Jul 22, 2025
Copy link

github-actions bot commented Jul 22, 2025

🔴 2025-08-01 11:22:16 UTC The validation of the Pull Request description has failed. Please update the description.

The changelog entry is less than 20 characters or missing.

Copy link

github-actions bot commented Jul 22, 2025

2025-07-22 17:54:52 UTC Pre-commit check linux-x86_64-release-asan for 628bef3 has started.
2025-07-22 17:55:06 UTC Artifacts will be uploaded here
2025-07-22 17:58:18 UTC ya make is running...
🟡 2025-07-22 19:44:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14512 14124 0 100 265 23

🟢 2025-07-22 19:45:51 UTC Build successful.
🟢 2025-07-22 19:46:20 UTC ydbd size 3.9 GiB changed* by +328 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ae2a63 merge: 628bef3 diff diff %
ydbd size 4 216 347 176 Bytes 4 216 347 504 Bytes +328 Bytes +0.000%
ydbd stripped size 1 461 202 744 Bytes 1 461 202 744 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 22, 2025

2025-07-22 17:54:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 628bef3 has started.
2025-07-22 17:55:08 UTC Artifacts will be uploaded here
2025-07-22 17:58:31 UTC ya make is running...
🟡 2025-07-22 19:09:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29932 28486 0 6 1407 33

2025-07-22 19:12:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-22 19:25:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
741 (only retried tests) 668 0 1 49 23

2025-07-22 19:25:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-22 19:37:21 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
254 (only retried tests) 181 0 1 49 23

🟢 2025-07-22 19:37:29 UTC Build successful.
🟢 2025-07-22 19:37:50 UTC ydbd size 2.2 GiB changed* by +32 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ae2a63 merge: 628bef3 diff diff %
ydbd size 2 398 149 784 Bytes 2 398 149 816 Bytes +32 Bytes +0.000%
ydbd stripped size 501 491 048 Bytes 501 491 048 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Jul 23, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 23, 2025
Copy link

github-actions bot commented Jul 23, 2025

2025-07-23 03:55:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 40dff12 has started.
2025-07-23 03:55:17 UTC Artifacts will be uploaded here
2025-07-23 03:58:36 UTC ya make is running...
🟡 2025-07-23 05:06:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29936 28500 0 2 1403 31

2025-07-23 05:08:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-23 05:21:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
295 (only retried tests) 221 0 1 50 23

2025-07-23 05:21:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-07-23 05:33:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
254 (only retried tests) 185 0 0 49 20

🟢 2025-07-23 05:33:29 UTC Build successful.
🟢 2025-07-23 05:33:48 UTC ydbd size 2.2 GiB changed* by +96 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3846947 merge: 40dff12 diff diff %
ydbd size 2 398 707 936 Bytes 2 398 708 032 Bytes +96 Bytes +0.000%
ydbd stripped size 501 591 272 Bytes 501 591 336 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 23, 2025

2025-07-23 03:55:12 UTC Pre-commit check linux-x86_64-release-asan for 40dff12 has started.
2025-07-23 03:55:26 UTC Artifacts will be uploaded here
2025-07-23 03:58:40 UTC ya make is running...
🟡 2025-07-23 05:53:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14515 14051 0 177 264 23

🟢 2025-07-23 06:11:40 UTC Build successful.
🟢 2025-07-23 06:12:13 UTC ydbd size 3.9 GiB changed* by +384 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3846947 merge: 40dff12 diff diff %
ydbd size 4 217 537 616 Bytes 4 217 538 000 Bytes +384 Bytes +0.000%
ydbd stripped size 1 461 635 704 Bytes 1 461 635 768 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Не очень понял, в чем проблема (в описание бы).
  2. Багфикс без теста выглядит странно.

@github-actions github-actions bot added bugfix and removed bugfix labels Aug 1, 2025
@nshestakov nshestakov enabled auto-merge (squash) August 1, 2025 12:49
@nshestakov nshestakov requested a review from CyberROFL August 1, 2025 12:49
Copy link

github-actions bot commented Aug 1, 2025

2025-08-01 12:49:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for f03d049 has started.
2025-08-01 12:49:54 UTC Artifacts will be uploaded here
2025-08-01 12:53:27 UTC ya make is running...
🟢 2025-08-01 14:21:09 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37190 34416 0 0 2744 30

🟢 2025-08-01 14:24:40 UTC Build successful.
🟢 2025-08-01 14:25:00 UTC ydbd size 2.2 GiB changed* by +21.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 966b630 merge: f03d049 diff diff %
ydbd size 2 409 609 688 Bytes 2 409 631 888 Bytes +21.7 KiB +0.001%
ydbd stripped size 503 299 720 Bytes 503 302 536 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 1, 2025

2025-08-01 12:49:53 UTC Pre-commit check linux-x86_64-release-asan for f03d049 has started.
2025-08-01 12:50:08 UTC Artifacts will be uploaded here
2025-08-01 12:53:24 UTC ya make is running...
🟡 2025-08-01 14:43:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14711 14325 0 101 261 24

🟢 2025-08-01 14:44:33 UTC Build successful.
🟢 2025-08-01 14:45:01 UTC ydbd size 3.9 GiB changed* by +504 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4562857 merge: f03d049 diff diff %
ydbd size 4 236 558 384 Bytes 4 236 558 888 Bytes +504 Bytes +0.000%
ydbd stripped size 1 467 010 776 Bytes 1 467 010 904 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit 1fcd6f2 into ydb-platform:main Aug 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants