Skip to content

Route all handler responses through monitoring #21480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 23, 2025
Merged

Route all handler responses through monitoring #21480

merged 7 commits into from
Jul 23, 2025
+57 −24

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Jul 22, 2025 •
edited
Loading

Changelog entry

Route all handler responses through monitoring #21482

Changelog category

  • Improvement

Description for reviewers

...

@StekPerepolnen StekPerepolnen requested a review from a team as a code owner July 22, 2025 10:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 10:34:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9bf7c53 has started.
⚪ 2025-07-22 10:34:33 UTC Artifacts will be uploaded here
⚪ 2025-07-22 10:38:01 UTC ya make is running...
⚫ 2025-07-22 10:38:29 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

🟢 2025-07-22 10:49:28 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 10:36:44 UTC Pre-commit check linux-x86_64-release-asan for 9bf7c53 has started.
⚪ 2025-07-22 10:36:58 UTC Artifacts will be uploaded here
⚫ 2025-07-22 10:38:27 UTC Check cancelled

@ydbot @actions-user
@galnat @anton-bobkov @StekPerepolnen
Update CHANGELOG.md for main:2025-06-15 (ydb-platform#19669)
e088f9e 
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Natasha Pirogova <galnat@ydb.tech>
Co-authored-by: anton-bobkov <anton-bobkov@yandex-team.ru>
@StekPerepolnen StekPerepolnen force-pushed the mon-streaming-response branch from 2f37125 to e088f9e Compare July 22, 2025 10:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 10:39:43 UTC Pre-commit check linux-x86_64-release-asan for e45abc7 has started.
⚪ 2025-07-22 10:39:47 UTC Artifacts will be uploaded here
⚪ 2025-07-22 10:43:02 UTC ya make is running...
🟡 2025-07-22 12:26:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15668 15174 0 180 291 23

🟢 2025-07-22 12:28:10 UTC Build successful.
🟢 2025-07-22 12:28:36 UTC ydbd size 3.9 GiB changed* by +16.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a973396 merge: e45abc7 diff diff %
ydbd size 4 215 591 976 Bytes 4 215 608 544 Bytes +16.2 KiB +0.000%
ydbd stripped size 1 460 982 168 Bytes 1 460 987 096 Bytes +4.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen changed the title Update CHANGELOG.md for main:2025-06-15 (#19669) Route all streaming responses through monitoring Jul 22, 2025
@StekPerepolnen StekPerepolnen changed the title Route all streaming responses through monitoring Route all handler responses through monitoring Jul 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 10:40:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for e45abc7 has started.
⚪ 2025-07-22 10:40:29 UTC Artifacts will be uploaded here
⚪ 2025-07-22 10:43:45 UTC ya make is running...
🟡 2025-07-22 11:58:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38115 35370 0 14 2696 35

⚪ 2025-07-22 12:01:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-22 12:16:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
615 (only retried tests) 560 0 8 26 21

⚪ 2025-07-22 12:16:38 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-22 12:28:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
261 (only retried tests) 233 0 8 0 20

🟢 2025-07-22 12:28:54 UTC Build successful.
🟢 2025-07-22 12:29:14 UTC ydbd size 2.2 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a973396 merge: e45abc7 diff diff %
ydbd size 2 397 729 376 Bytes 2 397 737 032 Bytes +7.5 KiB +0.000%
ydbd stripped size 501 438 312 Bytes 501 439 784 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen requested review from adameat and removed request for a team July 22, 2025 10:45
@adameat adameat requested a review from Copilot July 22, 2025 11:07
Copilot
Copilot AI reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a change to route all HTTP monitoring handler responses through a unified monitoring layer, addressing issue #21482. The changes refactor the authorization and response handling mechanism to ensure consistent monitoring coverage across all handlers.

Key Changes

  • Refactored THttpMonAuthorizedActorRequest to handle all responses regardless of authentication requirements
  • Added proper request cancellation handling and response proxying
  • Simplified handler routing by removing the conditional auth/non-auth path bifurcation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 12:44:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for ec0178b has started.
⚫ 2025-07-22 12:44:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 12:44:27 UTC Pre-commit check linux-x86_64-release-asan for ec0178b has started.
⚫ 2025-07-22 12:44:43 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the mon-streaming-response branch from 173c66b to b45266b Compare July 22, 2025 12:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 12:45:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for b84a69a has started.
⚪ 2025-07-22 12:46:03 UTC Artifacts will be uploaded here
⚪ 2025-07-22 12:49:21 UTC ya make is running...
⚫ 2025-07-22 13:07:27 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 12:48:35 UTC Pre-commit check linux-x86_64-release-asan for b84a69a has started.
⚪ 2025-07-22 12:48:48 UTC Artifacts will be uploaded here
⚪ 2025-07-22 12:52:11 UTC ya make is running...
⚫ 2025-07-22 13:07:35 UTC Check cancelled

adameat
adameat requested changes Jul 22, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:16:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for b57b07e has started.
⚪ 2025-07-22 13:16:50 UTC Artifacts will be uploaded here
⚪ 2025-07-22 13:20:17 UTC ya make is running...
⚫ 2025-07-22 13:23:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:17:17 UTC Pre-commit check linux-x86_64-release-asan for b57b07e has started.
⚪ 2025-07-22 13:17:21 UTC Artifacts will be uploaded here
⚪ 2025-07-22 13:20:36 UTC ya make is running...
⚫ 2025-07-22 13:23:20 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the mon-streaming-response branch from aac43f4 to c3e45fa Compare July 22, 2025 13:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:27:01 UTC Pre-commit check linux-x86_64-release-asan for fe61007 has started.
⚪ 2025-07-22 13:27:14 UTC Artifacts will be uploaded here
⚫ 2025-07-22 13:28:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:27:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for fe61007 has started.
⚪ 2025-07-22 13:27:16 UTC Artifacts will be uploaded here
⚫ 2025-07-22 13:28:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:30:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9237ebe has started.
⚪ 2025-07-22 13:30:23 UTC Artifacts will be uploaded here
⚫ 2025-07-22 13:31:45 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the mon-streaming-response branch from 301e64b to ed46ea3 Compare July 22, 2025 13:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:33:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0b25f8d has started.
⚪ 2025-07-22 13:33:33 UTC Artifacts will be uploaded here
⚪ 2025-07-22 13:36:51 UTC ya make is running...
⚫ 2025-07-22 14:07:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 13:33:43 UTC Pre-commit check linux-x86_64-release-asan for 0b25f8d has started.
⚪ 2025-07-22 13:33:56 UTC Artifacts will be uploaded here
⚪ 2025-07-22 13:37:24 UTC ya make is running...
⚫ 2025-07-22 14:06:54 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the mon-streaming-response branch from ed46ea3 to 1ea7b0e Compare July 22, 2025 14:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 14:12:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e90349 has started.
⚪ 2025-07-22 14:12:18 UTC Artifacts will be uploaded here
⚪ 2025-07-22 14:15:40 UTC ya make is running...
🟡 2025-07-22 16:01:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38157 35430 0 1 2693 33

⚪ 2025-07-22 16:04:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-22 16:14:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
395 (only retried tests) 375 0 0 0 20

🟢 2025-07-22 16:14:55 UTC Build successful.
🟢 2025-07-22 16:15:16 UTC ydbd size 2.2 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4542c8b merge: 7e90349 diff diff %
ydbd size 2 397 969 328 Bytes 2 397 978 176 Bytes +8.6 KiB +0.000%
ydbd stripped size 501 472 680 Bytes 501 474 280 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

⚪ 2025-07-22 14:12:05 UTC Pre-commit check linux-x86_64-release-asan for 7e90349 has started.
⚪ 2025-07-22 14:12:19 UTC Artifacts will be uploaded here
⚪ 2025-07-22 14:15:46 UTC ya make is running...
🟡 2025-07-22 16:44:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15709 15312 0 114 259 24

🟢 2025-07-22 16:46:01 UTC Build successful.
🟢 2025-07-22 16:46:27 UTC ydbd size 3.9 GiB changed* by +17.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4542c8b merge: 7e90349 diff diff %
ydbd size 4 215 984 632 Bytes 4 216 002 112 Bytes +17.1 KiB +0.000%
ydbd stripped size 1 461 077 976 Bytes 1 461 082 776 Bytes +4.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen requested a review from adameat July 22, 2025 16:30
adameat
adameat requested changes Jul 23, 2025
View reviewed changes
StekPerepolnen and others added 3 commits July 23, 2025 09:15
@StekPerepolnen @adameat
Update ydb/core/mon/mon.cpp
a0074ae 
Co-authored-by: Alexey Efimov <xeno@prnwatch.com>
@StekPerepolnen @adameat
Update ydb/core/mon/mon.cpp
378ba6f 
Co-authored-by: Alexey Efimov <xeno@prnwatch.com>
@StekPerepolnen @adameat
Update ydb/core/mon/mon.cpp
7a899f6 
Co-authored-by: Alexey Efimov <xeno@prnwatch.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 07:17:27 UTC Pre-commit check linux-x86_64-release-asan for 98a32cc has started.
⚪ 2025-07-23 07:17:57 UTC Artifacts will be uploaded here
⚪ 2025-07-23 07:21:47 UTC ya make is running...
⚫ 2025-07-23 07:46:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 07:18:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98a32cc has started.
⚪ 2025-07-23 07:18:50 UTC Artifacts will be uploaded here
⚪ 2025-07-23 07:22:12 UTC ya make is running...
⚫ 2025-07-23 07:46:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 07:47:35 UTC Pre-commit check linux-x86_64-release-asan for 3b72df8 has started.
⚪ 2025-07-23 07:50:34 UTC Artifacts will be uploaded here
⚪ 2025-07-23 07:54:33 UTC ya make is running...
🟡 2025-07-23 09:38:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15712 15308 0 114 264 26

🟢 2025-07-23 09:40:05 UTC Build successful.
🟢 2025-07-23 09:40:34 UTC ydbd size 3.9 GiB changed* by +15.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3846947 merge: 3b72df8 diff diff %
ydbd size 4 217 537 616 Bytes 4 217 553 576 Bytes +15.6 KiB +0.000%
ydbd stripped size 1 461 635 704 Bytes 1 461 639 992 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 07:50:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3b72df8 has started.
⚪ 2025-07-23 07:51:04 UTC Artifacts will be uploaded here
⚪ 2025-07-23 07:54:33 UTC ya make is running...
🟡 2025-07-23 09:14:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38164 35380 0 2 2743 39

⚪ 2025-07-23 09:17:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-23 09:29:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
455 (only retried tests) 380 0 0 49 26

🟢 2025-07-23 09:30:05 UTC Build successful.
🟢 2025-07-23 09:30:26 UTC ydbd size 2.2 GiB changed* by +9.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3846947 merge: 3b72df8 diff diff %
ydbd size 2 398 707 936 Bytes 2 398 717 592 Bytes +9.4 KiB +0.000%
ydbd stripped size 501 591 272 Bytes 501 593 000 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen merged commit 8f4bd11 into ydb-platform:main Jul 23, 2025
12 checks passed
@StekPerepolnen StekPerepolnen deleted the mon-streaming-response branch July 23, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@adameat adameat adameat approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StekPerepolnen @adameat @ydbot