Skip to content

User-defined Certificate Authority (CA) in asynchronous replication #21458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

User-defined Certificate Authority (CA) in asynchronous replication #21458

merged 2 commits into from
Jul 28, 2025

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 21, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Documentation (changelog entry is not required)

Description for reviewers

...

@CyberROFL CyberROFL linked an issue Jul 21, 2025 that may be closed by this pull request
Add support for a user-defined Certificate Authority (CA) in asynchronous replication #21353
Closed
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed new-feature labels Jul 21, 2025
@CyberROFL CyberROFL marked this pull request as ready for review July 21, 2025 18:51
@CyberROFL CyberROFL requested a review from a team as a code owner July 21, 2025 18:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

🟢 2025-07-21 18:52:31 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

⚪ 2025-07-21 18:52:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 885c3d2 has started.
⚪ 2025-07-21 18:52:36 UTC Artifacts will be uploaded here
⚪ 2025-07-21 18:55:03 UTC ya make is running...
🟢 2025-07-21 18:55:08 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-21 18:55:15 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2025 •
edited
Loading

⚪ 2025-07-21 18:52:57 UTC Pre-commit check linux-x86_64-release-asan for 885c3d2 has started.
⚪ 2025-07-21 18:53:10 UTC Artifacts will be uploaded here
⚪ 2025-07-21 18:55:40 UTC ya make is running...
🟢 2025-07-21 18:55:46 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-21 18:55:53 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (8)

⚠️ ru/concepts/vector_search.md: 57: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/concepts/vector_search.md: 58: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 130: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 131: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/reference/configuration/index.md: 711: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 712: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Секция конфигурации feature_flags {#feature_flags}"]

⚠️ ru/reference/configuration/index.md: 720: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 721: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Функциональные флаги"]

@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

Hey @ElenaAfina, it has been 30 business-hours since the author's last update, could you please review?

ElenaAfina
ElenaAfina requested changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@ElenaAfina ElenaAfina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавить пример вызова с CA_CERT

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 10:54:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for b9c485b has started.
⚪ 2025-07-23 10:54:57 UTC Artifacts will be uploaded here
⚪ 2025-07-23 10:57:23 UTC ya make is running...
🟢 2025-07-23 10:57:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 10:57:35 UTC Build successful.

@ydbot
Copy link
Collaborator

ydbot commented Jul 23, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

⚪ 2025-07-23 10:56:14 UTC Pre-commit check linux-x86_64-release-asan for b9c485b has started.
⚪ 2025-07-23 10:56:28 UTC Artifacts will be uploaded here
⚪ 2025-07-23 10:58:58 UTC ya make is running...
🟢 2025-07-23 10:59:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-23 10:59:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (8)

⚠️ ru/concepts/vector_search.md: 57: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/concepts/vector_search.md: 58: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 130: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/dev/vector-indexes.md: 131: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/reference/configuration/index.md: 711: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 712: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "## Секция конфигурации feature_flags {#feature_flags}"]

⚠️ ru/reference/configuration/index.md: 720: MD031 / blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```"]

⚠️ ru/reference/configuration/index.md: 721: MD022 / blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Above] [Context: "### Функциональные флаги"]

ElenaAfina
ElenaAfina previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@ElenaAfina ElenaAfina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blinkov blinkov dismissed ElenaAfina’s stale review July 28, 2025 04:20

to avoid triggering auto-merge

@blinkov blinkov enabled auto-merge (squash) July 28, 2025 04:20
@blinkov blinkov added the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2025
@ydbot
Copy link
Collaborator

ydbot commented Jul 28, 2025

🔄 New commits pushed — @ElenaAfina please take a look.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

⚪ 2025-07-28 04:37:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for f04c513 has started.
⚪ 2025-07-28 04:37:55 UTC Artifacts will be uploaded here
⚪ 2025-07-28 04:40:23 UTC ya make is running...
🟢 2025-07-28 04:40:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-28 04:40:34 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

⚪ 2025-07-28 04:37:59 UTC Pre-commit check linux-x86_64-release-asan for f04c513 has started.
⚪ 2025-07-28 04:38:15 UTC Artifacts will be uploaded here
⚪ 2025-07-28 04:40:46 UTC ya make is running...
🟢 2025-07-28 04:40:52 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-07-28 04:40:58 UTC Build successful.

fomichev3000
fomichev3000 approved these changes Jul 28, 2025
View reviewed changes
ydb/docs/ru/core/yql/reference/syntax/create-async-replication.md
@@ -20,6 +20,7 @@ WITH (option = value [, ...])
### Параметры {#params}

* `CONNECTION_STRING` — [строка соединения](../../../concepts/connect.md#connection_string) c базой-источником. Обязательный параметр.
* `CA_CERT` — [корневой сертификат для TLS](../../../concepts/connect.md#tls-cert). Необязательный параметр. Может быть указан, если база-источник поддерживает режим обмена данными с шифрованием (`CONNECTION_STRING` начинается с `grpcs://`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мне кажется, что здесь не хватает важных слов про то, когда этот параметр нужен. А он нужен, когда свой CA

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Эти слова есть на соседней странице.

@blinkov blinkov merged commit dba2e10 into ydb-platform:main Jul 28, 2025
18 checks passed
@CyberROFL CyberROFL deleted the async-repl-ca-cert-docs branch July 28, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@ElenaAfina ElenaAfina ElenaAfina left review comments

Assignees

@ElenaAfina ElenaAfina

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for a user-defined Certificate Authority (CA) in asynchronous replication
5 participants
@CyberROFL @ydbot @fomichev3000 @ElenaAfina @blinkov