-
Notifications
You must be signed in to change notification settings - Fork 702
[NOT-FOR-MERGE] Test simdjson and broken stream #21453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Include topic, partition and buffered message offsets
feed it with incorrect json_one_row stream with incorrect boundaries
🟢 |
…ken-stream Conflicts: ydb/tests/fq/yds/test_row_dispatcher.py
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
This code demonstrate lack of validation in json parsing in row dispatcher. We feed intentionally incorrect events (split by random boundary instead of json boundary), still rd parser accept them as correct.
I don't think this needs to be fixed (besides, simdjson parser is designed to accept specially crafted invalid json), but still.