Skip to content

Conversation

@hippocampus-web3
Copy link
Collaborator

@hippocampus-web3 hippocampus-web3 commented Jun 26, 2025

@dynst
Copy link
Collaborator

dynst commented Jun 26, 2025

This is a follow-up to #1424 and #1434, right? Besides prepareApprove, do these lines in approve (which calls prepareApprove before these lines) need changing too?

tx.gasLimit = BigInt(gasLimit.toString())
tx.gasPrice = BigInt(gasPrice.toString())

And a line in transfer.

tx.gasLimit = BigInt(txGasLimit.toString())

And it'll be a major API break, but hopefully #1406 wipes away all these BigNumber-to-BigInt conversions someday.

@hippocampus-web3 hippocampus-web3 marked this pull request as draft June 26, 2025 16:52
@hippocampus-web3
Copy link
Collaborator Author

At some point, we could consider addressing the change from bignumber.js, but it's so deeply integrated into the library that I'm not sure the time spent would be worth the benefit gained

@hippocampus-web3 hippocampus-web3 marked this pull request as ready for review June 27, 2025 09:39
@hippocampus-web3 hippocampus-web3 merged commit 0512310 into master Jun 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants