Coverity warning fixes #8907
Draft
Coverity warning fixes #8907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Jun 20, 2025
wolfcrypt/src/asn.c
Outdated
|
|
||
| int ParseCertRelative(DecodedCert* cert, int type, int verify, void* cm, | ||
| WOLFSSL_LOCAL int ParseCertRelative(DecodedCert* cert, int type, int verify, void* cm, |
There was a problem hiding this comment.
This needs to be in the header, not the .c file.
There was a problem hiding this comment.
Make sure the header and .c definitions match. Remove the comment.
src/tls.c
Outdated
| @@ -9384,8 +9384,9 @@ static int TLSX_KeyShare_ProcessEcc_ex(WOLFSSL* ssl, | |||
| break; | |||
| #endif | |||
| default: | |||
| /* unsupported curve */ | |||
| curveId = ECC_CURVE_INVALID; | |||
There was a problem hiding this comment.
Please revert this. The curveId not used can just be solved with the (void)curveId below.
wolfcrypt/src/pkcs12.c
Outdated
| @@ -830,7 +830,10 @@ int wc_d2i_PKCS12_fp(const char* file, WC_PKCS12** pkcs12) | |||
| wc_PKCS12_free(*pkcs12); | |||
| *pkcs12 = NULL; | |||
| } | |||
| XFREE(buf, NULL, DYNAMIC_TYPE_TMP_BUFFER); | |||
| if (buf != NULL) { | |||
There was a problem hiding this comment.
XFREE already checks NULL. Just add the buf = NULL;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potential fixes for the Coverity warnings addressed in the support ticket.
Accidentally closed last pr for the same changes and it won't let me reopen for some reason.
Fixes zd#20029
Testing
How did you test?
Checklist