fix(core): update chainId retrieval logic to consider syncConnectedChain configuration #4711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #4680
Generated hooks from wagmi-cli were ignoring the syncConnectedChain configuration setting and always prioritizing the connected account's chainId over the config's default chainId. This meant that setting syncConnectedChain: false had no effect on generated hooks, requiring users to explicitly provide a chainId parameter to every hook call when they wanted hooks to work regardless of the connected network.
Solution
Updated the chainId resolution logic to respect the syncConnectedChain configuration:
Behavior after fix: