Skip to content

fix(core): update chainId retrieval logic to consider syncConnectedChain configuration #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yigiterdev
Copy link

Problem

Fixes #4680
Generated hooks from wagmi-cli were ignoring the syncConnectedChain configuration setting and always prioritizing the connected account's chainId over the config's default chainId. This meant that setting syncConnectedChain: false had no effect on generated hooks, requiring users to explicitly provide a chainId parameter to every hook call when they wanted hooks to work regardless of the connected network.

Solution

Updated the chainId resolution logic to respect the syncConnectedChain configuration:

Behavior after fix:

When syncConnectedChain: true (default): Uses account.chainId if available, falls back to configChainId
When syncConnectedChain: false: Uses configChainId directly, ignoring connected account's chain

Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: ffaf19c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 3:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wagmi-cli] hooks default to account chainId instead of global config
1 participant