Skip to content

Refactor kArray #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Refactor kArray #439

wants to merge 3 commits into from

Conversation

waltsims
Copy link
Owner

This PR cleans up the kArray object and uses inheritance to specify the "Element" object.

Still TODO:

  • Use typing to reduce checks
  • Use new classes for "Array" generation
  • Add deprecation warnings
  • Add get offgrid point methods to element?

@waltsims waltsims requested a review from faridyagubbayli July 16, 2024 04:16
waltsims
waltsims commented Jul 16, 2024
View reviewed changes
tests/matlab_test_data_collectors/python_testers/kWaveArray_test.py
integration_points=np.array([[1, 1, 1, 2, 2, 2, 3, 3, 3], [1, 2, 3, 1, 2, 3, 1, 2, 3]], dtype=np.float32),
integration_points=np.array([[1, 1, 1, 2, 2, 2, 3, 3, 3], [1, 2, 3, 1, 2, 3, 1, 2, 3]]),
measure=9,
element_dim=2,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change the signature of the current methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faridyagubbayli faridyagubbayli Awaiting requested review from faridyagubbayli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waltsims