SIP protocol #410
Merged
SIP protocol #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jesusprubio! The team likely won't get to review for a couple of days, but always appreciate your pulls! |
j-baines
reviewed
Jul 21, 2025
j-baines
approved these changes
Jul 21, 2025
terrorbyte
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
This is awesome, really appreciate all the work here. I second that this is a lot to comb over, but I did a quick review and a few little comments about potential randomness, docs, and error messages. All of these of which can be improved a bit at a later date if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the huge PR. If you prefer I could split it in smaller ones. :)