Skip to content

support silu vectorization #21521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stickingjh
Copy link

@stickingjh stickingjh commented Jul 24, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Support silu vectorization if d is multiple of vec size, later odd dim vectorization will be supported. The support is similar to flashinfer support. From local testing, perf is improved by about 60-70%.

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a vectorized CUDA kernel for SiLU activation to improve performance when the tensor dimension is a multiple of the vector size. The changes include the new kernel, a dispatch mechanism to select the appropriate kernel, and updated tests to cover both the vectorized and non-vectorized paths. My review identified two critical issues concerning memory alignment in the new CUDA kernel. Correcting these will ensure the stability and correctness of the vectorized implementation. Once these are addressed, this will be a solid performance improvement.

@stickingjh stickingjh force-pushed the support_silu_vec branch 2 times, most recently from 9c4a79f to e6762a9 Compare July 24, 2025 11:37
Signed-off-by: jindih <jindih@nvidia.com>
@LucasWilkinson
Copy link
Collaborator

why is the griddepcontrol needed? doesnt seem to overlapping anything

@LucasWilkinson LucasWilkinson self-requested a review July 29, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants