feat(isAlpha, isAlphanumeric): add support for Indic locales (ta-IN, te-IN, kn-IN, ml-IN, gu-IN, pa-IN, or-IN) #2576

avadootharajesh · 2025-07-20T07:56:07Z

This commit introduces Indic language support into isAlpha and isAlphanumeric methods.

Languages added:

Tamil (ta-IN) | Reference Character Set
Telugu (te-IN) | Reference Character Set
Kannada (kn-IN) | Reference Character Set
Malayalam (ml-IN) | Reference Character Set
Gujarati (gu-IN) | Reference Character Set
Punjabi (pa-IN) | Reference Character Set
Odia (or-IN) | Reference Character Set

Test Result

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2025-07-20T07:56:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72573b3) to head (c458883).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2576   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2539    +4     
  Branches       641       641           
=========================================
+ Hits          2535      2539    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

avadootharajesh · 2025-07-20T08:00:32Z

Hey reviewer!

Added support for Indian languages 🎉
Added basic support for Indian languages in the validator.
Tested a few cases, things look good. Open to feedback!

let me know If I have to do anything else...

Copilot

Pull Request Overview

This PR adds support for seven Indic languages (Tamil, Telugu, Kannada, Malayalam, Gujarati, Punjabi, and Odia) to the isAlpha and isAlphanumeric validator functions. The implementation includes Unicode character ranges for each language, appropriate decimal handling, and comprehensive test coverage.

Adds Unicode regex patterns for seven Indic locales covering their respective character ranges
Updates decimal and comma decimal configurations for the new locales
Provides comprehensive test coverage with valid and invalid test cases for each language

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/lib/alpha.js	Adds Unicode regex patterns for Indic languages and updates decimal configurations
test/validators.test.js	Adds comprehensive test cases for all seven new Indic language validators
README.md	Updates documentation to include the new supported locales in isAlpha and isAlphanumeric descriptions

Comments suppressed due to low confidence (1)

test/validators.test.js:1988

The Bengali (bn-IN) locale is being tested but was not mentioned in the PR title or description as one of the new Indic locales being added. This test appears to be for an existing locale rather than a newly added one.

  it('should validate Bengali alpha strings', () => {

avadootharajesh · 2025-07-21T04:49:06Z

Are there any other issues?
Cuz bengali test was added by someone else, hence I have mentioned what I have done
As it ( bengali ) is existing, I did not take a step to change it Or fakely add it to my pr
@Copilot @rubiin

avadootharajesh · 2025-07-24T06:16:50Z

@chriso @rubiin @profnandaa Am I needed to do any other changes or the code is perfect to be merged ?

test/validators.test.js

WikiRik · 2025-08-03T13:52:33Z

README.md

@@ -88,8 +88,8 @@ Validator                               | Description
 **equals(str, comparison)**             | check if the string matches the comparison.
 **isAbaRouting(str)**               | check if the string is an ABA routing number for US bank account / cheque.
 **isAfter(str [, options])**            | check if the string is a date that is after the specified date.<br/><br/>`options` is an object that defaults to `{ comparisonDate: Date().toString() }`.<br/>**Options:**<br/>`comparisonDate`: Date to compare to. Defaults to `Date().toString()` (now).
-**isAlpha(str [, locale, options])**    | check if the string contains only letters (a-zA-Z).<br/><br/>`locale` is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'bn', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'eo', 'es-ES', 'fa-IR', 'fi-FI', 'fr-CA', 'fr-FR', 'he', 'hi-IN', 'hu-HU', 'it-IT', 'kk-KZ', 'ko-KR', 'ja-JP', 'ku-IQ', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'si-LK', 'sl-SI', 'sk-SK', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA']` and defaults to `en-US`. Locale list is `validator.isAlphaLocales`. `options` is an optional object that can be supplied with the following key(s): `ignore` which can either be a String or RegExp of characters to be ignored e.g. " -" will ignore spaces and -'s.
-**isAlphanumeric(str [, locale, options])**      | check if the string contains only letters and numbers (a-zA-Z0-9).<br/><br/>`locale` is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bn', 'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'eo', 'es-ES', 'fa-IR', 'fi-FI', 'fr-CA', 'fr-FR', 'he', 'hi-IN', 'hu-HU', 'it-IT', 'kk-KZ', 'ko-KR', 'ja-JP','ku-IQ', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'si-LK', 'sl-SI', 'sk-SK', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA']`) and defaults to `en-US`. Locale list is `validator.isAlphanumericLocales`. `options` is an optional object that can be supplied with the following key(s): `ignore` which can either be a String or RegExp of characters to be ignored e.g. " -" will ignore spaces and -'s.
+**isAlpha(str [, locale, options])**    | check if the string contains only letters (a-zA-Z).<br/><br/>`locale` is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'bn', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'eo', 'es-ES', 'fa-IR', 'fi-FI', 'fr-CA', 'fr-FR', 'he', 'hi-IN', 'ta-IN', 'te-IN', 'kn-IN', 'ml-IN', 'gu-IN', 'pa-IN', 'or-IN', 'bn-IN', 'hu-HU', 'it-IT', 'kk-KZ', 'ko-KR', 'ja-JP', 'ku-IQ', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'si-LK', 'sl-SI', 'sk-SK', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA']` and defaults to `en-US`. Locale list is `validator.isAlphaLocales`. `options` is an optional object that can be supplied with the following key(s): `ignore` which can either be a String or RegExp of characters to be ignored e.g. " -" will ignore spaces and -'s.


These should be sorted alphabetically based on the first part (e.g. ta, te) instead of all added after hi-IN.

test/validators.test.js

WikiRik · 2025-08-03T13:53:52Z

src/lib/alpha.js

+export const indicLocales = ['ta-IN', 'te-IN', 'kn-IN', 'ml-IN', 'gu-IN', 'pa-IN', 'or-IN'];
+
+for (let i = 0; i < indicLocales.length; i++) {
+  const locale = indicLocales[i];
+  decimal[locale] = '.';
+}


I think this is not needed because you have added it to commaDecimal already

Removed unwanted npm-debug.log ( Generated at my end )

avadootharajesh · 2025-08-03T16:08:49Z

Changes included:

Sorted locales in the alpha.js file and the README file in lexicographical order.
Added isAlphanumeric test cases for the newly added Indic locales.
Removed redundant locale specifications from the decimal validator since they are already covered under commaDecimal.
( Made the requested changes. Please check. @WikiRik @rubiin )

Test Results

Checklist

Only relevant files changed, no stray files.
README/documentation updated accordingly.
Tests added and passing for new Indic locales.
Unicode reference links provided for all added locales.

Thank you for reviewing! @WikiRik
Feel free to ask for any clarifications.

WikiRik · 2025-08-03T18:20:26Z

src/lib/alpha.js

Please undo all the changes in this file related to the sorting. We only need to sort the list in README.md. While we want to sort this in the future, sorting it now creates unnecessary merge conflicts with the other open PRs for isAlpha/isAlphanumeric

WikiRik · 2025-08-03T18:21:00Z

test/validators.test.js

@@ -1918,7 +2012,6 @@ describe('Validators', () => {
      ],
    });
  });
-


Please undo this stylistic change

WikiRik · 2025-08-03T18:21:04Z

test/validators.test.js

@@ -1934,7 +2027,6 @@ describe('Validators', () => {
      ],
    });
  });
-


Please undo this stylistic change

WikiRik · 2025-08-03T18:22:07Z

test/validators.test.js

@@ -2699,6 +2791,118 @@ describe('Validators', () => {
      ],
    });
  });
+  it('should validate Tamil alphanumeric strings', () => {


Please add valid expectations with decimals as well to all locales

WikiRik · 2025-08-03T18:23:13Z

README.md

@@ -88,8 +88,8 @@ Validator                               | Description
 **equals(str, comparison)**             | check if the string matches the comparison.
 **isAbaRouting(str)**               | check if the string is an ABA routing number for US bank account / cheque.
 **isAfter(str [, options])**            | check if the string is a date that is after the specified date.<br/><br/>`options` is an object that defaults to `{ comparisonDate: Date().toString() }`.<br/>**Options:**<br/>`comparisonDate`: Date to compare to. Defaults to `Date().toString()` (now).
-**isAlpha(str [, locale, options])**    | check if the string contains only letters (a-zA-Z).<br/><br/>`locale` is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'bn', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'eo', 'es-ES', 'fa-IR', 'fi-FI', 'fr-CA', 'fr-FR', 'he', 'hi-IN', 'hu-HU', 'it-IT', 'kk-KZ', 'ko-KR', 'ja-JP', 'ku-IQ', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'si-LK', 'sl-SI', 'sk-SK', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA']` and defaults to `en-US`. Locale list is `validator.isAlphaLocales`. `options` is an optional object that can be supplied with the following key(s): `ignore` which can either be a String or RegExp of characters to be ignored e.g. " -" will ignore spaces and -'s.
-**isAlphanumeric(str [, locale, options])**      | check if the string contains only letters and numbers (a-zA-Z0-9).<br/><br/>`locale` is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bn', 'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'eo', 'es-ES', 'fa-IR', 'fi-FI', 'fr-CA', 'fr-FR', 'he', 'hi-IN', 'hu-HU', 'it-IT', 'kk-KZ', 'ko-KR', 'ja-JP','ku-IQ', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'si-LK', 'sl-SI', 'sk-SK', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA']`) and defaults to `en-US`. Locale list is `validator.isAlphanumericLocales`. `options` is an optional object that can be supplied with the following key(s): `ignore` which can either be a String or RegExp of characters to be ignored e.g. " -" will ignore spaces and -'s.
+**isAlpha(str [, locale, options])**    | check if the string contains only letters (a-zA-Z).<br/><br/>`locale` is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'bn', 'bn-IN', 'cs-CZ', 'da-DK', 'de-DE', 'el-GR', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'eo', 'es-ES', 'fa-IR', 'fi-FI', 'fr-CA', 'fr-FR', 'gu-IN', 'he', 'hi-IN', 'hu-HU', 'it-IT', 'ja-JP', 'kk-KZ', 'kn-IN', 'ko-KR', 'ku-IQ', 'ml-IN', 'nb-NO', 'nl-NL', 'nn-NO', 'or-IN', 'pa-IN', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'si-LK', 'sk-SK', 'sl-SI', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'ta-IN', 'te-IN', 'th-TH', 'tr-TR', 'uk-UA']` and defaults to `en-US`. Locale list is `validator.isAlphaLocales`. `options` is an optional object that can be supplied with the following key(s): `ignore` which can either be a String or RegExp of characters to be ignored e.g. " -" will ignore spaces and -'s.


Thanks for fixing the mistakes that we had in the sorting here!

avadootharajesh added 2 commits July 20, 2025 12:25

feat: add alpha and alphanumeric regex support for Indic languages

189c37a

feat: add alpha and alphanumeric regex support for Indic languages

c458883

rubiin requested a review from Copilot July 20, 2025 08:55

Copilot AI reviewed Jul 20, 2025

View reviewed changes

WikiRik requested changes Aug 3, 2025

View reviewed changes

avadootharajesh and others added 2 commits August 3, 2025 21:20

alphaNumeric Tests for indic locales and Sorted Locales

5c37ed5

Delete npm-debug.log

3a1896f

Removed unwanted npm-debug.log ( Generated at my end )

avadootharajesh requested a review from WikiRik August 3, 2025 16:11

WikiRik requested changes Aug 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(isAlpha, isAlphanumeric): add support for Indic locales (ta-IN, te-IN, kn-IN, ml-IN, gu-IN, pa-IN, or-IN) #2576

feat(isAlpha, isAlphanumeric): add support for Indic locales (ta-IN, te-IN, kn-IN, ml-IN, gu-IN, pa-IN, or-IN) #2576

avadootharajesh commented Jul 20, 2025

Uh oh!

codecov bot commented Jul 20, 2025

Uh oh!

avadootharajesh commented Jul 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

avadootharajesh commented Jul 21, 2025 •

edited

Loading

Uh oh!

avadootharajesh commented Jul 24, 2025

Uh oh!

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

avadootharajesh commented Aug 3, 2025 •

edited

Loading

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

WikiRik Aug 3, 2025

Uh oh!

Uh oh!

@@ @@ -1918,7 +2012,6 @@ describe('Validators', () => { @@
                     ],
                   });
                 });

@@ @@ -1934,7 +2027,6 @@ describe('Validators', () => { @@
                     ],
                   });
                 });

Uh oh!

feat(isAlpha, isAlphanumeric): add support for Indic locales (ta-IN, te-IN, kn-IN, ml-IN, gu-IN, pa-IN, or-IN) #2576

Are you sure you want to change the base?

feat(isAlpha, isAlphanumeric): add support for Indic locales (ta-IN, te-IN, kn-IN, ml-IN, gu-IN, pa-IN, or-IN) #2576

Conversation

avadootharajesh commented Jul 20, 2025

Languages added:

Test Result

Checklist

Uh oh!

codecov bot commented Jul 20, 2025

Codecov Report

Uh oh!

avadootharajesh commented Jul 20, 2025

Hey reviewer!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

avadootharajesh commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avadootharajesh commented Jul 24, 2025

Uh oh!

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

avadootharajesh commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes included:

Test Results

Checklist

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

WikiRik Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

avadootharajesh commented Jul 21, 2025 •

edited

Loading

avadootharajesh commented Aug 3, 2025 •

edited

Loading