feat(lightclient): add CommitClientStatus message to persist client s… #4859
+170
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
benluelo
reviewed
Jul 20, 2025
lib/ibc-union-spec/src/path.rs
Outdated
|
|
||
| impl IbcStorePathKey for ClientStatusPath { | ||
| type Spec = IbcUnion; | ||
| type Value = u8; // repr(u8) status stored as raw byte |
There was a problem hiding this comment.
we should move the status enum into this crate
| Active, | ||
| Expired, | ||
| Frozen, | ||
| Active = 0, |
There was a problem hiding this comment.
this needs to be non-zero (i.e. starting at 1) such that it can be reliably differentiated from an empty storage value
benluelo
reviewed
Jul 20, 2025
| #[serde(deny_unknown_fields)] | ||
| pub struct MsgCommitClientStatus { | ||
| pub client_id: ClientId, | ||
| pub height: Option<u64>, |
|
also please verify your commits as per our contributing guide. |
0xumutkk
force-pushed
the
feat/lightclient-commit-status
branch
from
55a5626 to
8e70297
Compare
benluelo
requested changes
Jul 21, 2025
| @@ -2171,6 +2194,10 @@ pub fn query(deps: Deps, _env: Env, msg: QueryMsg) -> Result<Binary, ContractErr | |||
| )?; | |||
| Ok(to_json_binary(&status)?) | |||
| } | |||
| QueryMsg::GetCommittedStatus { client_id, .. } => { | |||
There was a problem hiding this comment.
if the field is unused, remove it from the msg
lib/ibc-union-spec/Cargo.toml
Outdated
| @@ -28,7 +28,7 @@ voyager-primitives = { workspace = true } | |||
| ibc-union-spec = { workspace = true, features = ["ethabi", "schemars", "serde"] } | |||
|
|
|||
| [features] | |||
| default = [] | |||
| default = ["serde"] | |||
There was a problem hiding this comment.
remove, do not add default features
lib/ibc-union-spec/src/path.rs
Outdated
| Frozen = 3, | ||
| } | ||
|
|
||
| /// Represents the path to a client's committed status (Active, Expired, etc.) |
There was a problem hiding this comment.
Suggested change
| /// Represents the path to a client's committed status (Active, Expired, etc.) | |
| /// Represents the path to a client's committed [`Status`]. |
lib/ibc-union-spec/src/path.rs
Outdated
|
|
||
| impl IbcStorePathKey for ClientStatusPath { | ||
| type Spec = IbcUnion; | ||
| type Value = u8; // repr(u8) status stored as raw byte |
| ) -> RpcResult<Option<u8>> { | ||
| let status = self | ||
| .query_smart::<_, u8>( | ||
| &ibc_union_msg::query::QueryMsg::GetStatus { client_id }, |
There was a problem hiding this comment.
this is the wrong query; you need to use GetCommittedStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new 'CommitClientStatus' message to explicitly commit the client's status (Active, Expired, or Frozen) into state storage as a hashed commitment using 'store_commit'.
Closes #4842