refactor(chains): Improve chain info consistency and maintainability #4835
+44
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alphena-EK
requested review from
cor,
benluelo,
Swepool and
ehegnes
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the chain information definitions, enhancing maintainability, consistency, and correctness.
Key Changes:
Refactor (DRY): A common IMAGE_BASE_URL constant has been introduced to eliminate repetitive image URL strings. All chain definitions now use this constant, making future updates easier and reducing the risk of typos.
Fix (Babylon Testnet): Corrected a critical configuration error in babylonTestnet where the stakeCurrency was incorrectly set to "tBABY". It has been changed to "BABY" to be consistent with the feeCurrencies and what is available in the currencies array. This prevents potential integration issues with wallets and UIs.
Chore (URL Formatting): Removed trailing slashes from the rpc and rest endpoints for babylonTestnet to ensure a consistent URL format across all chain definitions in the file.