Discuss supported options in CollationType docs #6778
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback. |
components/locale_core/src/preferences/extensions/unicode/keywords/collation.rs
Outdated
Show resolved
Hide resolved
sffc
changed the title
| /// | ||
| /// # Supported Values | ||
| /// | ||
| /// Not all collation orderings are always supported by ICU4X: |
There was a problem hiding this comment.
| /// Not all collation orderings are always supported by ICU4X: | |
| /// Not all collation orderings are always supported: |
| CollationType { | ||
| /// A previous version of the ordering, for compatibility | ||
| ("compat" => Compat), | ||
| /// Dictionary style ordering (such as in Sinhala) | ||
| ("dict" => Dict), | ||
| /// The default Unicode collation element table order | ||
| /// | ||
| /// 🛈 `icu::collator` does not support the `ducet` ordering. See [`CollationType`]. |
There was a problem hiding this comment.
For me, too, on Apple platforms. The character seems appropriate for this purpose, though.
There was a problem hiding this comment.
I'm sure we can find an equivalent character that is more widely supported.
| CollationType { | ||
| /// A previous version of the ordering, for compatibility | ||
| ("compat" => Compat), | ||
| /// Dictionary style ordering (such as in Sinhala) | ||
| ("dict" => Dict), | ||
| /// The default Unicode collation element table order | ||
| /// | ||
| /// 🛈 `icu::collator` does not support the `ducet` ordering. See [`CollationType`]. |
There was a problem hiding this comment.
For me, too, on Apple platforms. The character seems appropriate for this purpose, though.
| ("search" => Search), | ||
| /// Special collation type for Korean initial consonant search | ||
| /// | ||
| /// 🛈 `icu::collator` does not include search collation rules by default. See [`CollationType`]. |
There was a problem hiding this comment.
Also, even if built by datagen, the code doesn't support the data shape for this one. See #1941.
Please change this one to say something along the lines of "ICU4X does not support Korean search collations."
It is not clear from
icu_collatorthat search rules are not supported; they just silently fall back to the standard rules. I'm adding a link to the function inicu_provider_exportwhere they can be added.