Fix crash when using AdditionalManifestFiles on 32-bit Windows targets #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that appears when you add additional manifest files while targeting 32-bit Windows. The crash is caused by
EnvironmentVariableResolver
for that platform being null.To reproduce, use this (assuming
[project.SourceRootPath]\app.manifest
points to a valid manifest file location) and try generating targeting Win32 (not Win64) platform:conf.Options.Add(Options.CSharp.GenerateManifests.Enabled); conf.AdditionalManifestFiles.Add(@"[project.SourceRootPath]\app.manifest");