Implement cleanup of temporary plugin directories on next command execution #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskrbasu
reviewed
Jul 24, 2025
There was a problem hiding this comment.
IMO doing this cleanup in the plugin cmd is better rather than in rootCmd.
Steampipe - https://github.com/turbot/steampipe/blob/develop/cmd/plugin.go#L78-L82
…anup across multiple commands. This ensures that any leftover temporary directories from previous crashes or interrupted installations are removed before executing plugin operations.
kaidaguerre
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on pipe-fittings: turbot/pipe-fittings#741