Skip to content

TPRD-1638: adding missed argument #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 25, 2025

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Jul 24, 2025

@mc-nv mc-nv self-assigned this Jul 24, 2025
@mc-nv mc-nv force-pushed the mchornyi/TPRD-1638/adding-missed-argument branch from 423dddf to 4e0ef28 Compare July 24, 2025 21:38
@mc-nv mc-nv marked this pull request as ready for review July 25, 2025 16:24
Copy link
Contributor

@dmitry-tokarev-nv dmitry-tokarev-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing things up!
1 question about risk of moving cmake to pip install.

@mc-nv mc-nv merged commit 3772013 into r25.07 Jul 25, 2025
3 checks passed
@mc-nv mc-nv deleted the mchornyi/TPRD-1638/adding-missed-argument branch July 25, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants