Skip to content

Build: Build using the PA binaries and whl if available. #8043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions Dockerfile.sdk
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ ARG TRITON_MODEL_ANALYZER_REPO_TAG=main
ARG TRITON_ENABLE_GPU=ON
ARG JAVA_BINDINGS_MAVEN_VERSION=3.8.4
ARG JAVA_BINDINGS_JAVACPP_PRESETS_TAG=1.5.8

ARG PERF_ANALYZER_BUILD=ON
# DCGM version to install for Model Analyzer
ARG DCGM_VERSION=3.3.6

Expand Down Expand Up @@ -131,11 +131,11 @@ RUN cmake -DCMAKE_INSTALL_PREFIX=/workspace/install \
-DTRITON_THIRD_PARTY_REPO_TAG=${TRITON_THIRD_PARTY_REPO_TAG} \
-DTRITON_ENABLE_PERF_ANALYZER=OFF \
-DTRITON_ENABLE_CC_HTTP=ON -DTRITON_ENABLE_CC_GRPC=ON \
-DTRITON_ENABLE_PYTHON_HTTP=OFF -DTRITON_ENABLE_PYTHON_GRPC=OFF \
-DTRITON_ENABLE_PYTHON_HTTP=ON -DTRITON_ENABLE_PYTHON_GRPC=ON \
-DTRITON_ENABLE_JAVA_HTTP=ON \
-DTRITON_ENABLE_EXAMPLES=ON -DTRITON_ENABLE_TESTS=ON \
-DTRITON_ENABLE_GPU=${TRITON_ENABLE_GPU} /workspace/client
RUN make -j16 cc-clients java-clients && \
RUN make -j16 cc-clients java-clients python-clients && \
rm -fr ~/.m2

# TODO: PA will rebuild the CC clients since it depends on it.
Expand All @@ -145,7 +145,8 @@ RUN make -j16 cc-clients java-clients && \
# the python client until now. Post-migration we should focus
# effort on de-tangling these flows.
WORKDIR /workspace/pa_build
RUN cmake -DCMAKE_INSTALL_PREFIX=/workspace/install \
RUN if [ "$PERF_ANALYZER_BUILD" = "ON" ]; then \
cmake -DCMAKE_INSTALL_PREFIX=/workspace/install \
-DTRITON_VERSION=`cat /workspace/TRITON_VERSION` \
-DTRITON_REPO_ORGANIZATION=${TRITON_REPO_ORGANIZATION} \
-DTRITON_COMMON_REPO_TAG=${TRITON_COMMON_REPO_TAG} \
Expand All @@ -161,12 +162,17 @@ RUN cmake -DCMAKE_INSTALL_PREFIX=/workspace/install \
-DTRITON_ENABLE_PYTHON_GRPC=ON \
-DTRITON_PACKAGE_PERF_ANALYZER=ON \
-DTRITON_ENABLE_GPU=${TRITON_ENABLE_GPU} \
/workspace/perf_analyzer
RUN make -j16 perf-analyzer python-clients

RUN pip3 install build \
&& cd /workspace/perf_analyzer/genai-perf \
&& python3 -m build --wheel --outdir /workspace/install/python
/workspace/perf_analyzer && \
make -j16 perf-analyzer && \
pip3 install build \
&& cd /workspace/perf_analyzer/genai-perf && \
python3 -m build --wheel --outdir /workspace/install/python; \
else \
tar -xzf /workspace/perf_analyzer/perf_analyzer*.tar.gz -C /workspace/install/bin && \
echo "Perf Analyzer binaries was extracted and not build"; \
mkdir -p /workspace/install/python && \
cp perf_analyzer/genai_perf-*.whl /workspace/install/python/; \
fi

# Install Java API Bindings
RUN if [ "$TARGETPLATFORM" = "linux/amd64" ]; then \
Expand Down Expand Up @@ -243,6 +249,9 @@ RUN pip3 install install/python/genai_perf-*.whl
# Install the dependencies needed to run the client examples. These
# are not needed for building but including them allows this image to
# be used to run the client examples.

RUN pip3 install install/python/genai_perf-*.whl;

Comment on lines +251 to +253
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed--it's already run directly above.

RUN pip3 install --upgrade "numpy<2" pillow attrdict && \
find install/python/ -maxdepth 1 -type f -name \
"tritonclient-*linux*.whl" | xargs printf -- '%s[all]' | \
Expand Down Expand Up @@ -285,4 +294,4 @@ ENV LD_LIBRARY_PATH=/workspace/install/lib:${LD_LIBRARY_PATH}
ENV LD_LIBRARY_PATH=/opt/hpcx/ompi/lib:${LD_LIBRARY_PATH}

# Set TCMALLOC_RELEASE_RATE for users setting LD_PRELOAD with tcmalloc
ENV TCMALLOC_RELEASE_RATE=200
ENV TCMALLOC_RELEASE_RATE=200
38 changes: 0 additions & 38 deletions qa/L0_perf_analyzer/nginx.conf

This file was deleted.

95 changes: 0 additions & 95 deletions qa/L0_perf_analyzer/perf_analyzer_profile_export_schema.json

This file was deleted.

Loading
Loading