-
Notifications
You must be signed in to change notification settings - Fork 97
Add Trino Scheduler as add on #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Trino Scheduler as add on #799
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Hi I have moved the Starburst Scheduler Guide here, as suggested in https://github.com/trinodb All checks are passing — looking forward to your feedback! Additionally, for your reference, I have developed a Python package (starburst-scheduler) that automates query scheduling and alerting for Starburst. We are actively using this in our project. Python PyPI: (https://pypi.org/project/starburst-scheduler) Please advise on the best way to share this more broadly with the community. Thank you again! |
Fix YAML error and improve formatting.
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
The CLA needs to be emailed and then processed by @martint In terms of the actual content of this PR .. we do not host actual documentation for project.. you will have to put that with the code of the scheduler. You can add a section to the scheduled to the add-ons page by adding a section into _data/tools.yml file .. it is alphabetically sorted and I can help with a review. Also in terms of naming the project .. I assume you have to get approval from Starburst to actually use that name .. from a trino project perspective you should talk about how it works with Trino itself.. and if it works with other distributions of Trino thats fine and you can mention that but Trino should be first. |
… remove standalone doc
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mosabua ,
I have resolved and updated the PR:
✅ Full documentation is now only in my GitHub repo.
✅ PR only contains the tools.yml
entry (addons section), with owner: community
as discussed.
✅ I have removed the standalone doc as requested.
Thank you again for your guidance — looking forward to your review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add a logo as well. I dont know what happens without. Also make sure to verify the render locally or the deploy preview here.
_data/tools.yml
Outdated
@@ -1958,6 +1958,12 @@ | |||
url: https://www.youtube.com/watch?v=2qwBcKmQSn0 | |||
- urltext: Announcement blog post | |||
url: /blog/2023/09/28/trino-gateway | |||
- name: Trino Scheduler (Starburst-compatible) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Trino Scheduler (Starburst-compatible) | |
- name: Trino Scheduler |
move the Starburst compatible into the description or the docs.
_data/tools.yml
Outdated
- name: Trino Scheduler (Starburst-compatible) | ||
category: addons | ||
owner: community | ||
description: Python CLI tool to automate and schedule Trino queries. Works with Trino OSS, Starburst Enterprise, and Starburst Galaxy. Supports multi-cluster usage and Mattermost alert integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Python CLI tool to automate and schedule Trino queries. Works with Trino OSS, Starburst Enterprise, and Starburst Galaxy. Supports multi-cluster usage and Mattermost alert integration. | |
description: The Trino Scheduler is a Python command line tool to automate and schedule Trino queries. Works with Trino, Starburst Enterprise, and Starburst Galaxy. Supports multi-cluster usage and Mattermost alert integration. |
Also fix wrapping to 80 columns with
_data/tools.yml
Outdated
category: addons | ||
owner: community | ||
description: Python CLI tool to automate and schedule Trino queries. Works with Trino OSS, Starburst Enterprise, and Starburst Galaxy. Supports multi-cluster usage and Mattermost alert integration. | ||
link: https://github.com/karranikhilreddy99/starburst_scheduler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix to correct data format with urltext and url as in the other section otherwise it wont render
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Hi Mosabua, I have updated the tools.yml entry per your feedback:
Please let me know if any further adjustments are needed — thanks again for the review! |
Starburst Galaxy. Supports multi-cluster usage and Mattermost alert | ||
integration. | ||
links: | ||
- urltext: GitHub Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- urltext: GitHub Repository | |
- urltext: GitHub repository |
@martint can you please process the CLA? |
TSF feedback.. please update the image to be more unique and not be a derivative of the Trino logo that damages the overall branding consistency. You could even give it a unique name and just refer to Trino and whatever engine it works for in the description. |
Summary
This PR adds new documentation under
overview/
:✅ Starburst Scheduler Guide →
starburst-scheduler.md
Starburst Scheduler Guide
Introduction to Starburst Scheduler — an open-source Python package to automate Starburst queries:
👉 GitHub: https://github.com/karranikhilreddy99/starburst_scheduler
I have signed the Individual CLA.
Looking forward to feedback — thank you!
Best regards,
Nikhil Reddy Karra